restore: tell CRIU to use existing namespaces #2583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI complains:
|
kolyshkin
reviewed
Sep 10, 2020
kolyshkin
reviewed
Sep 10, 2020
kolyshkin
reviewed
Sep 10, 2020
140ed67 to
9808cad
Compare
|
@kolyshkin Thanks for the review. I changed the code and also used |
rst0git
reviewed
Sep 11, 2020
9808cad to
0690d50
Compare
kolyshkin
reviewed
Sep 15, 2020
6944ef0 to
4cd7069
Compare
|
With the changes tests are failing... Because the code is just wrong. Will fix it. |
runc already tells CRIU to restore into an existing network or PID namespace if there is a path to a namespace specified in config.json. PID and network have special handling in CRIU using CRIU's inherit_fd interface. For UTS, IPC and MOUNT namespaces CRIU can join those existing namespaces using CRIU's join_ns interface. This is especially interesting for environments where containers are running in a pod which already has running containers (pause for example) with namespaces configured and the restored container needs to join these namespaces. CRIU has no support to join an existing CGROUP namespace (yet?) why restoring a container with a path specified to a CGROUP namespace will be aborted by runc. CRIU would have support to restore a container into an existing time namespace, but runc does not yet seem to support time namespaces. Signed-off-by: Adrian Reber <areber@redhat.com>
4cd7069 to
2ccefa6
Compare
|
Now it works as intended. |
rst0git
approved these changes
Sep 30, 2020
|
@AkihiroSuda @mrunalp PTAL |
AkihiroSuda
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runc already tells CRIU to restore into an existing network or PID namespace if there is a path to a namespace specified in config.json.
PID and network have special handling in CRIU using CRIU's inherit_fd interface.
For UTS, IPC and MOUNT namespaces CRIU can join those existing namespaces using CRIU's join_ns interface.
This is especially interesting for environments where containers are running in a pod which already has running containers (pause for example) with namespaces configured and the restored container needs to join these namespaces.
CRIU has no support to join an existing CGROUP namespace (yet?) why restoring a container with a path specified to a CGROUP namespace will be aborted by runc.
CRIU would have support to restore a container into an existing time namespace, but runc does not yet seem to support time namespaces.