cgroup2: do not parse /proc/cgroups #2160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/proc/cgroups is meaningless for v2 and should be ignored. https://github.com/torvalds/linux/blob/v5.3/Documentation/admin-guide/cgroup-v2.rst#deprecated-v1-core-features * Now GetAllSubsystems() parses /sys/fs/cgroup/cgroup.controller, not /proc/cgroups. The function result also contains "pseudo" controllers: {"devices", "freezer"}. As it is hard to detect availability of pseudo controllers, pseudo controllers are always assumed to be available. * Now IOGroupV2.Name() returns "io", not "blkio" Fix opencontainers#2155 opencontainers#2156 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/proc/cgroupsis meaningless for v2 and should be ignored.https://github.com/torvalds/linux/blob/v5.3/Documentation/admin-guide/cgroup-v2.rst#deprecated-v1-core-features
Now
GetAllSubsystems()parses/sys/fs/cgroup/cgroup.controller, not/proc/cgroups.The function result also contains "pseudo" controllers:
{"devices", "freezer"}.As it is hard to detect availability of pseudo controllers, pseudo controllers are always assumed to be available.
Now
IOGroupV2.Name()returns"io", not"blkio".Fix #2155 #2156
Signed-off-by: Akihiro Suda akihiro.suda.cz@hco.ntt.co.jp