cr: don't dump network devices and their configuration #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolyshkin
reviewed
Jul 11, 2018
checkpoint.go
Outdated
| @@ -127,6 +127,9 @@ var namespaceMapping = map[specs.LinuxNamespaceType]int{ | |||
| func setEmptyNsMask(context *cli.Context, options *libcontainer.CriuOpts) error { | |||
| var nsmask int | |||
|
|
|||
| /* Runc doesn't manage network devices and their configuration */ | |||
| nsmask = unix.CLONE_NEWNET | |||
|
|
|||
There was a problem hiding this comment.
Perhaps just
- var nsmask int
+ /* Runc doesn't manage network devices and their configuration */
+ nsmask := unix.CLONE_NEWNET?
RunC doesn't manage network devices and their configuration, so it is impossible to describe external dependencies to restore them back. This means that all users have to set --empty-ns network, so let's do this by default. Signed-off-by: Andrei Vagin <avagin@openvz.org>
|
LGTM |
|
LGTM |
|
LGTM |
kolyshkin
added a commit
to kolyshkin/moby
that referenced
this pull request
Jul 31, 2018
This is mostly to include opencontainers/runc#1840 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RunC doesn't manage network devices and their configurations,
so it is impossible to describe external dependencies to restore them
back.
This means that all users have to set --empty-ns network, so let's do
this by default.
Signed-off-by: Andrei Vagin avagin@openvz.org