Merge pull request #171 from Mashimiao/rm-dup-error

remove duplicated error printing
opencontainers · Aug 14, 2017 · da84dc9 · da84dc9
2 parents 1ddba1b + 24eb890
commit da84dc9
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 8 deletions.
diff --git a/cmd/oci-image-tool/create.go b/cmd/oci-image-tool/create.go
@@ -68,10 +68,6 @@ func createHandle(context *cli.Context) error {
 
 	}
 
-	if err != nil {
-		fmt.Printf("creating failed: %v\n", err)
-	}
-
 	return err
 }
 

diff --git a/cmd/oci-image-tool/unpack.go b/cmd/oci-image-tool/unpack.go
@@ -65,9 +65,6 @@ func unpackHandle(context *cli.Context) error {
 		err = fmt.Errorf("cannot unpack %q", v.typ)
 	}
 
-	if err != nil {
-		fmt.Printf("unpacking failed: %v\n", err)
-	}
 	return err
 }
 

diff --git a/image/descriptor.go b/image/descriptor.go
@@ -76,7 +76,7 @@ func findDescriptor(w walker, name string) (*v1.Descriptor, error) {
 		return nil
 	}); err {
 	case nil:
-		return nil, fmt.Errorf("index.json: descriptor not found")
+		return nil, fmt.Errorf("index.json: descriptor %q not found", name)
 	case errEOW:
 		return &d, nil
 	default:
-Original file line number
+Diff line change
@@ Expand Up / @@ -68,10 +68,6 @@ func createHandle(context *cli.Context) error { @@
     	}
-    	if err != nil {
-    		fmt.Printf("creating failed: %v\n", err)
-    	}
     	return err
     }
@@ Expand Down @@