Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add p4RT id to component/chassis/ #625

Merged
merged 10 commits into from
Sep 3, 2022
Merged

Add p4RT id to component/chassis/ #625

merged 10 commits into from
Sep 3, 2022

Conversation

dplore
Copy link
Member

@dplore dplore commented Apr 23, 2022

(M) release/models/p4rt/openconfig-p4rt.yang

Adds a p4rt id leaf for the chassis component. This is intended to be used as a controller defined identifier which can be related to interface/oc-p4rt:id and integrated-circuit/oc-p4rt:node-id

module: openconfig-platform
  +--rw components
     +--rw component* [name]
        +--rw chassis
        |  +--rw config
        |  |  +--rw oc-p4rt:id?   uint32
        |  +--ro state
        |  |  +--ro oc-p4rt:id?   uint32

@dplore dplore requested a review from robshakir April 23, 2022 07:06
@OpenConfigBot
Copy link

OpenConfigBot commented Apr 23, 2022

Compatibility Report for commit 41be379:
yanglint@SO 1.10.17

@dplore dplore requested review from robshakir and ghostli123 August 20, 2022 01:49
@dplore dplore requested review from rolandphung, ghostli123 and earies and removed request for ghostli123, rolandphung and earies August 23, 2022 21:17
Copy link

@ghostli123 ghostli123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the implementation!

@dplore dplore requested review from robshakir and removed request for earies and robshakir August 25, 2022 16:52
Copy link
Contributor

@robshakir robshakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for constraining this to the P4RT module, I think this is the only place it has relevance.

@dplore
Copy link
Member Author

dplore commented Aug 29, 2022

Thanks Rob, will cover this in the Aug 30 Openconfig Operators meeting

@dplore dplore changed the title Add component chassis-id Add p4RT id to component/chassis/ Aug 29, 2022
@dplore
Copy link
Member Author

dplore commented Aug 31, 2022

This was covered in Aug 30 meeting without objection. Will merge on Sep 2nd. (14 days after commits which moved this to the p4rt model) if there are no further changes requested.

@ghostli123
Copy link

Thanks for the help, Darren!

@dplore
Copy link
Member Author

dplore commented Sep 2, 2022

/gcbrun

@dplore dplore merged commit 7ca380c into master Sep 3, 2022
@dplore dplore deleted the dplore/chassisid branch September 3, 2022 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants