System_banner Cisco deviation #3853
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important The terms of service for this installation has not been accepted. Please ask the Organization owners to visit the Gemini Code Assist Admin Console to sign it. |
Pull Request Functional Test Report for #3853 / b5c2717Virtual Devices
Hardware Devices
|
Pull Request Test Coverage Report for Build 13558375764Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
ram-mac
reviewed
Feb 27, 2025
| if testCase.banner == "" { | ||
| if v, ok := gnmi.LookupConfig(t, dut, config.Config()).Val(); ok && v != "" { | ||
| t.Errorf("MOTD Banner not empty") | ||
| if testCase.banner == deviations.BannerDelimiter(dut)+""+deviations.BannerDelimiter(dut) { |
There was a problem hiding this comment.
We need to ensure that empty strings are still supported. This current deviation prevents that
There was a problem hiding this comment.
I've open a bug for this, I'm working with the dev team to fix this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating deviation : banner_empty_delimiter_unsupported for the empty string banner.
applying deviation: banner_delimiter since Cisco currently requires a delimiter on the banners.