-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnoi 2.2 plq test for 400g zrp #3830
base: main
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 13536609726Details
💛 - Coveralls |
...qualification/tests/zrp_packet_link_qualification_test/zrp_packet_link_qualification_test.go
Outdated
Show resolved
Hide resolved
...qualification/tests/zrp_packet_link_qualification_test/zrp_packet_link_qualification_test.go
Outdated
Show resolved
Hide resolved
/fptest hardware |
/fptest physical |
/fptest physical |
uuid: "6c70f15c-b4da-4f98-95b1-27d97cceed05" | ||
plan_id: "gNOI-2.2" | ||
description: "Packet-based Link Qualification on 400G ZR Plus links" | ||
testbed: TESTBED_DUT_400ZR_PLUS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this testbed doesn't exist, I think you'll need to add it to the topologies/
folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feb 24 17:52:46 fp-presubmit-8488ecd3-8067-4d9d-a2c5-afe6e59057f2 google_metadata_script_runner[1066]: startup-script: + echo 'Running test gNOI-2.2: Packet-based Link Qualification on 400G ZR Plus links'
Feb 24 17:52:46 fp-presubmit-8488ecd3-8067-4d9d-a2c5-afe6e59057f2 google_metadata_script_runner[1066]: startup-script: Running test gNOI-2.2: Packet-based Link Qualification on 400G ZR Plus links
Feb 24 17:52:46 fp-presubmit-8488ecd3-8067-4d9d-a2c5-afe6e59057f2 google_metadata_script_runner[1066]: startup-script: + gcloud pubsub topics publish featureprofiles-badge-status --project disco-idea-817 --message '{"path":"badges/3830/cb8abb30fb0409bbde6b1fbb28322770856bc309/ZmVhdHVyZS9nbm9pL3BhY2tldF9saW5rX3F1YWxpZmljYXRpb24vdGVzdHMvenJwX3BhY2tldF9saW5rX3F1YWxpZmljYXRpb25fdGVzdA.NOKIA_7250_IXR-10e.svg","status":"running"}'
Feb 24 17:52:47 fp-presubmit-8488ecd3-8067-4d9d-a2c5-afe6e59057f2 google_metadata_script_runner[1066]: startup-script: messageIds:
Feb 24 17:52:47 fp-presubmit-8488ecd3-8067-4d9d-a2c5-afe6e59057f2 google_metadata_script_runner[1066]: startup-script: - '14101467606755347'
Feb 24 17:52:47 fp-presubmit-8488ecd3-8067-4d9d-a2c5-afe6e59057f2 google_metadata_script_runner[1066]: startup-script: + go test -v ./feature/gnoi/packet_link_qualification/tests/zrp_packet_link_qualification_test/... -timeout 0 -alsologtostderr --dut_vendor=NOKIA '--dut_hardware=regex:^7250-.*'
Feb 24 17:57:10 fp-presubmit-8488ecd3-8067-4d9d-a2c5-afe6e59057f2 google_metadata_script_runner[1066]: startup-script: E0224 17:57:10.985866 13569 runtests.go:43] Unable to initialize test metadata: no testbed file for testbed TESTBED_DUT_400ZR_PLUS
Feb 24 17:57:10 fp-presubmit-8488ecd3-8067-4d9d-a2c5-afe6e59057f2 google_metadata_script_runner[1066]: startup-script: === RUN TestMain
Feb 24 17:57:10 fp-presubmit-8488ecd3-8067-4d9d-a2c5-afe6e59057f2 google_metadata_script_runner[1066]: startup-script: testbed path not specified
Feb 24 17:57:10 fp-presubmit-8488ecd3-8067-4d9d-a2c5-afe6e59057f2 google_metadata_script_runner[1066]: startup-script: --- FAIL: TestMain (0.00s)
Feb 24 17:57:10 fp-presubmit-8488ecd3-8067-4d9d-a2c5-afe6e59057f2 google_metadata_script_runner[1066]: startup-script: F0224 17:57:10.986409 13569 ondatra.go:60]
Feb 24 17:57:11 fp-presubmit-8488ecd3-8067-4d9d-a2c5-afe6e59057f2 google_metadata_script_runner[1066]: startup-script: FAIL github.com/openconfig/featureprofiles/feature/gnoi/packet_link_qualification/tests/zrp_packet_link_qualification_test 0.539s
Feb 24 17:57:11 fp-presubmit-8488ecd3-8067-4d9d-a2c5-afe6e59057f2 google_metadata_script_runner[1066]: startup-script: FAIL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The testbed is already under topologies/dut_400zr_plus.testbed. Is the error specific to Nokia?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, this testbed isn't fully/properly defined. If you search for the testbed string, you'll see it's missing from:
featureprofiles/internal/fptest/runtests.go
Lines 68 to 78 in 5b8036a
func testbedPathFromMetadata() (string, error) { | |
testbed := metadata.Get().Testbed | |
testbedToFile := map[mpb.Metadata_Testbed]string{ | |
mpb.Metadata_TESTBED_DUT: "dut.testbed", | |
mpb.Metadata_TESTBED_DUT_DUT_4LINKS: "dutdut.testbed", | |
mpb.Metadata_TESTBED_DUT_ATE_2LINKS: "atedut_2.testbed", | |
mpb.Metadata_TESTBED_DUT_ATE_4LINKS: "atedut_4.testbed", | |
mpb.Metadata_TESTBED_DUT_ATE_9LINKS_LAG: "atedut_9_lag.testbed", | |
mpb.Metadata_TESTBED_DUT_DUT_ATE_2LINKS: "dutdutate.testbed", | |
mpb.Metadata_TESTBED_DUT_ATE_8LINKS: "atedut_8.testbed", | |
mpb.Metadata_TESTBED_DUT_400ZR: "dut_400zr.testbed", |
Note, I was able to detect this problem by using the /fptest
command here. See the instructions at https://gist.github.com/OpenConfigBot/7dadd09b7c3133c9d8bc0d08fcb19b46
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is added now.
Add TESTBED_DUT_400ZR_PLUS testbed
The new plq test,