Add DP-2.2 - Ingress policer matching NHG set by gRIBI #3554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11603745082Details
💛 - Coveralls |
vishnureddybadveli
previously approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Overall changes are good:
Could you please resolve the merge part?
test: {
<<<<<<< HEAD
id: "DP-2.2"
id: "DP-2.4"
main
readme: "https://github.com/openconfig/featureprofiles/blob/main/feature/qos/otg_tests/ingress_police_nhg/README.md"
}
dplore
commented
Oct 31, 2024
Comment on lines
+285
to
+291
| id: "DP-2.2" | ||
| readme: "https://github.com/openconfig/featureprofiles/blob/main/feature/qos/otg_tests/ingress_police_nhg/README.md" | ||
| } | ||
| test: { | ||
| id: "DP-2.4" | ||
| readme: "https://github.com/openconfig/featureprofiles/blob/main/feature/qos/otg_tests/ingress_police_default/README.md" | ||
| } |
There was a problem hiding this comment.
Fixed DP-2.2 reference and added DP-2.4 reference which was missing
vishnureddybadveli
approved these changes
Oct 31, 2024
ANISH-GOTTAPU
pushed a commit
to open-traffic-generator/featureprofiles
that referenced
this pull request
Nov 28, 2024
alshabib
pushed a commit
to alshabib/featureprofiles
that referenced
this pull request
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.