Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RT 7.11: Updated the script with deviation for ASpath set #3365

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

RT 7.11: Updated the script with deviation for ASpath set #3365

wants to merge 12 commits into from

Conversation

s-nandu
Copy link
Contributor

@s-nandu s-nandu commented Aug 7, 2024 •
edited
Loading

RT 7.11: Updated the script with deviation for ASpath set

Added policy result as ACCEPT for policy "match_community_regex"

(Moved RT 7.4 to #3607 )

@s-nandu s-nandu requested review from a team as code owners August 7, 2024 00:50
@s-nandu s-nandu requested a review from a team August 7, 2024 00:50
@s-nandu s-nandu marked this pull request as draft August 7, 2024 00:51
@OpenConfigBot
Copy link

OpenConfigBot commented Aug 7, 2024 •
edited
Loading

Pull Request Functional Test Report for #3365 / 074661d

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
 RT-7.11: BGP Policy - Import/Export Policy Action Using Multiple Criteria
Cisco 8000E status
 RT-7.11: BGP Policy - Import/Export Policy Action Using Multiple Criteria
Cisco XRd status
 RT-7.11: BGP Policy - Import/Export Policy Action Using Multiple Criteria
Juniper ncPTX status
 RT-7.11: BGP Policy - Import/Export Policy Action Using Multiple Criteria
Nokia SR Linux status
 RT-7.11: BGP Policy - Import/Export Policy Action Using Multiple Criteria
Openconfig Lemming status
 RT-7.11: BGP Policy - Import/Export Policy Action Using Multiple Criteria

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
 RT-7.11: BGP Policy - Import/Export Policy Action Using Multiple Criteria
Cisco 8808 status
 RT-7.11: BGP Policy - Import/Export Policy Action Using Multiple Criteria
Juniper PTX10008 status
 RT-7.11: BGP Policy - Import/Export Policy Action Using Multiple Criteria
Nokia 7250 IXR-10e status
 RT-7.11: BGP Policy - Import/Export Policy Action Using Multiple Criteria

Help

@coveralls
Copy link

coveralls commented Aug 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12303596124

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%
Totals Coverage Status
Change from base Build 12300163041: 0.0%
Covered Lines: 1983
Relevant Lines: 3588
💛 - Coveralls

@s-nandu s-nandu marked this pull request as ready for review September 4, 2024 05:00
@cprabha cprabha requested a review from dplore as a code owner September 11, 2024 18:24
@dplore dplore self-assigned this Sep 11, 2024
@dplore
Copy link
Member

dplore commented Sep 12, 2024

Fixes #3415

@dplore dplore linked an issue Sep 12, 2024 that may be closed by this pull request
Usage of NEXT_STATEMENT policy result in RT-7.11-import_export_multi_test #3415
Open
@self-maurya self-maurya requested a review from dplore October 9, 2024 03:39
@dplore
Copy link
Member

dplore commented Nov 12, 2024

@s-nandu please let us know if you will be resolving the comments.

@s-nandu s-nandu mentioned this pull request Nov 22, 2024
Open
@s-nandu s-nandu changed the title RT 7.4 & RT 7.11: Updated the script with deviation for ASpath set RT 7.11: Updated the script with deviation for ASpath set Nov 22, 2024
@dplore
Copy link
Member

dplore commented Dec 3, 2024

@s-nandu there are still conflicts to be resolved

@dplore dplore removed their assignment Dec 3, 2024
@ram-mac
Copy link
Contributor

ram-mac commented Dec 17, 2024

@s-nandu - Can you please resolve the conflicts?

@lvaish05 lvaish05 removed their assignment Jan 22, 2025
@ram-mac
Copy link
Contributor

ram-mac commented Feb 10, 2025

@Juniper - Please resolve the conflicts in this PR so i can validate it.
The conflicts are in the testcode itself.

@ram-mac ram-mac self-requested a review February 10, 2025 10:57
@s-nandu s-nandu requested review from a team as code owners February 12, 2025 03:18
@s-nandu
Copy link
Contributor Author

s-nandu commented Feb 12, 2025

@ram-mac , resolved all the conflicts. Please merge the code after review
@dplore , all comments have been resolved but the pull request still says there are unresolved comments. Please help rectify

@ram-mac
Copy link
Contributor

ram-mac commented Feb 12, 2025 •
edited
Loading

@s-nandu - i validated this change and looks like it is breaking one vendor during gnmi.Replace(ln502) is breaking with the following error "An unexpected element "match-as-path-set" is present".

ram-mac
ram-mac approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@ram-mac ram-mac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and the changes works for most vendors

rohit-rp
rohit-rp requested changes Feb 20, 2025
View reviewed changes
feature/bgp/policybase/otg_tests/import_export_multi_test/import_export_multi_test.go

switch dut.Vendor() {
case ondatra.JUNIPER:
config = juniperCLI()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don not agree on the use of CLI to pass a test, if a feature is not supported let it fail until supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit-rp rohit-rp rohit-rp requested changes

@ram-mac ram-mac ram-mac approved these changes

@dplore dplore Awaiting requested review from dplore

Requested changes must be addressed to merge this pull request.

Assignees

@ram-mac ram-mac

Labels
juniper-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Usage of NEXT_STATEMENT policy result in RT-7.11-import_export_multi_test
9 participants
@s-nandu @OpenConfigBot @coveralls @dplore @ram-mac @rohit-rp @self-maurya @lvaish05 @cprabha