Add the initial ISIS base and adjacency feature profile #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On branch isis-1 Changes to be committed: new file: isis/base_isis_and_adjacenty/feature.textproto Add the initial ISIS base and adjacency feature profile.
sthesayi
reviewed
Dec 22, 2021
|
@drautio friendly reminder, can you respond to the comments? |
On branch isis-1 Your branch is up to date with 'origin/isis-1'. Changes to be committed: new file: isis/isis_auth/feature.textproto renamed: isis/base_isis_and_adjacenty/feature.textproto -> isis/isis_base/feature.textproto address comments
|
I addressed all the comments and uploaded new files. |
sthesayi
approved these changes
Jan 24, 2022
| } | ||
| telemetry_path { | ||
| path: "/network-instances/network-instance/protocols/protocol/isis/interfaces/interface/authentication/key/state/auth-password" | ||
| } |
There was a problem hiding this comment.
We should have a dependency on isis_base feature profile.
sgirishj
added a commit
to sgirishj/featureprofiles
that referenced
this pull request
Oct 12, 2022
… to check for DUT vendor at the start of the test with the help of a map and moved PID finding logic into its own function
liulk
pushed a commit
that referenced
this pull request
Oct 12, 2022
* Code commit for TE-8.1: DUT Daemon Failure * Updated file permissions and made some minor changes in the code comments * Updated file permissions again * Removed newline in the end * Addressed review comments: updated Arista and Cisco gRIBI daemon names, changed gNOI kill signal from sigkill to sigterm and changed traffic flow setup as suggested. * Addressed review comments #2: removed testTraffic and reused startTraffic/stopAndVerifyTraffic instead * Addressed review comments #3: Gribi -> GRIBI, added support to check for DUT vendor at the start of the test with the help of a map and moved PID finding logic into its own function
singh-prem
pushed a commit
to mingyangcisco/featureprofiles
that referenced
this pull request
Dec 13, 2022
* Code commit for TE-8.1: DUT Daemon Failure * Updated file permissions and made some minor changes in the code comments * Updated file permissions again * Removed newline in the end * Addressed review comments: updated Arista and Cisco gRIBI daemon names, changed gNOI kill signal from sigkill to sigterm and changed traffic flow setup as suggested. * Addressed review comments openconfig#2: removed testTraffic and reused startTraffic/stopAndVerifyTraffic instead * Addressed review comments openconfig#3: Gribi -> GRIBI, added support to check for DUT vendor at the start of the test with the help of a map and moved PID finding logic into its own function
prinikasn
pushed a commit
that referenced
this pull request
Jun 30, 2023
* Code commit for TE-8.1: DUT Daemon Failure * Updated file permissions and made some minor changes in the code comments * Updated file permissions again * Removed newline in the end * Addressed review comments: updated Arista and Cisco gRIBI daemon names, changed gNOI kill signal from sigkill to sigterm and changed traffic flow setup as suggested. * Addressed review comments #2: removed testTraffic and reused startTraffic/stopAndVerifyTraffic instead * Addressed review comments #3: Gribi -> GRIBI, added support to check for DUT vendor at the start of the test with the help of a map and moved PID finding logic into its own function
nsadhasivam
added a commit
to nsadhasivam/featureprofiles
that referenced
this pull request
Oct 30, 2024
nsadhasivam
added a commit
that referenced
this pull request
Oct 30, 2024
alshabib
pushed a commit
to alshabib/featureprofiles
that referenced
this pull request
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the initial ISIS base and adjacency feature profile.