Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FNT] Forwarding viability Test aggregate_all_not_viable_test #2953

Merged
merged 4 commits into from
Jun 25, 2024
Merged

[FNT] Forwarding viability Test aggregate_all_not_viable_test #2953

merged 4 commits into from
Jun 25, 2024

Conversation

rahulsy26
Copy link
Contributor

@rahulsy26 rahulsy26 commented May 3, 2024 •
edited
Loading

Summary:
This code is to Test forwarding-viable with LAG and routing

Ensure that when all LAG member become set with forwarding-viable == FALSE.

forwarding-viable=false impact only transmit traffic on all member port.
All member ports set with forwarding-viable=false can receive all type of traffic and forward it normally (same as with forwarding-viable=true)
ISIS adjacency is established on LAG port w/ all member set to forwarding-viable == FALSE
Traffic that normally egress LAG with all members set to forwarding-viable == FALSE is forwarded by the next best egress interface/LAG.

@rahulsy26 rahulsy26 requested review from nflath and self-maurya May 3, 2024 04:02
@rahulsy26 rahulsy26 requested review from a team as code owners May 3, 2024 04:02
@rahulsy26 rahulsy26 requested review from a team and michaelore May 3, 2024 04:02
@OpenConfigBot
Copy link

OpenConfigBot commented May 3, 2024 •
edited
Loading

Pull Request Functional Test Report for #2953 / a73e579

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
 RT-5.7: Aggregate Not Viable All
 2c22160e Log
Cisco 8000E status
 RT-5.7: Aggregate Not Viable All
 855b278b Log
Cisco XRd status
 RT-5.7: Aggregate Not Viable All
 cbd5dd5d Log
Juniper ncPTX status
 RT-5.7: Aggregate Not Viable All
 fe2aff92 Log
Nokia SR Linux status
 RT-5.7: Aggregate Not Viable All
 94b5e823 Log
Openconfig Lemming status
 RT-5.7: Aggregate Not Viable All
 1ffef6c9 Log

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
 RT-5.7: Aggregate Not Viable All
Cisco 8808 status
 RT-5.7: Aggregate Not Viable All
Juniper PTX10008 status
 RT-5.7: Aggregate Not Viable All
Nokia 7250 IXR-10e status
 RT-5.7: Aggregate Not Viable All

Help

@coveralls
Copy link

coveralls commented May 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9657332583

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.5%
Totals Coverage Status
Change from base Build 9657106637: 0.0%
Covered Lines: 1983
Relevant Lines: 3573
💛 - Coveralls

@rahulsy26 rahulsy26 force-pushed the aggregate_all_not_forwarding_viable_test branch 7 times, most recently from 9895a65 to f5fab17 Compare May 3, 2024 13:24
@rahulsy26 rahulsy26 force-pushed the aggregate_all_not_forwarding_viable_test branch 6 times, most recently from feabd53 to f12b41e Compare May 6, 2024 15:47
@rahulsy26 rahulsy26 force-pushed the aggregate_all_not_forwarding_viable_test branch from d160fec to d9a2574 Compare May 9, 2024 13:19
@LimeHat LimeHat mentioned this pull request May 10, 2024
Open
@rahulsy26 rahulsy26 force-pushed the aggregate_all_not_forwarding_viable_test branch from 91796ca to d9a2574 Compare May 10, 2024 07:55
@rahulsy26 rahulsy26 force-pushed the aggregate_all_not_forwarding_viable_test branch 3 times, most recently from 3eae60c to dc16060 Compare June 21, 2024 02:48
@nflath nflath closed this Jun 22, 2024
@nflath nflath reopened this Jun 22, 2024
nflath
nflath previously approved these changes Jun 22, 2024
View reviewed changes
@rahulsy26 rahulsy26 force-pushed the aggregate_all_not_forwarding_viable_test branch from 7d47058 to dc16060 Compare June 25, 2024 05:56
rahulsy26 added 3 commits June 25, 2024 05:59
@rahulsy26
Updating Metadata
6a87873
@rahulsy26
Revert "Updating Metadata"
5236afc 
This reverts commit 45c5e722786ceee387fb74f763ea5a685b07dc80.
@rahulsy26
Reapply "Updating Metadata"
3fbd22a 
This reverts commit d8bc4adba96589aa6e6f109a5ea2679f4621ae8a.
@rahulsy26 rahulsy26 force-pushed the aggregate_all_not_forwarding_viable_test branch from dc16060 to 643e7ee Compare June 25, 2024 06:05
@rahulsy26 rahulsy26 force-pushed the aggregate_all_not_forwarding_viable_test branch from 643e7ee to a73e579 Compare June 25, 2024 06:08
@rahulsy26 rahulsy26 requested a review from nflath June 25, 2024 06:11
@rahulsy26 rahulsy26 removed the request for review from dplore June 25, 2024 07:01
rahulsy26
rahulsy26 commented Jun 25, 2024
View reviewed changes
Copy link
Contributor Author

@rahulsy26 rahulsy26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@rahulsy26 rahulsy26 dismissed stale reviews from dplore and nachikethas June 25, 2024 07:05

Change Request are Done

@self-maurya self-maurya merged commit 17ce6e7 into main Jun 25, 2024
15 checks passed
@self-maurya self-maurya deleted the aggregate_all_not_forwarding_viable_test branch June 25, 2024 07:07
@octpetre octpetre mentioned this pull request Jun 25, 2024
Closed
frasieroh pushed a commit to aristanetworks/openconfig-featureprofiles that referenced this pull request Jun 26, 2024
@rahulsy26 @frasieroh
[FNT] Forwarding viability Test aggregate_all_not_viable_test (openco…
ff1ae27 
…nfig#2953)

* Updating Metadata

* Revert "Updating Metadata"

This reverts commit 45c5e722786ceee387fb74f763ea5a685b07dc80.

* Reapply "Updating Metadata"

This reverts commit d8bc4adba96589aa6e6f109a5ea2679f4621ae8a.

* Updating Deviation and Go File
ANISH-GOTTAPU pushed a commit to open-traffic-generator/featureprofiles that referenced this pull request Jul 10, 2024
@rahulsy26 @ANISH-GOTTAPU
[FNT] Forwarding viability Test aggregate_all_not_viable_test (openco…
e57647a 
…nfig#2953)

* Updating Metadata

* Revert "Updating Metadata"

This reverts commit 45c5e722786ceee387fb74f763ea5a685b07dc80.

* Reapply "Updating Metadata"

This reverts commit d8bc4adba96589aa6e6f109a5ea2679f4621ae8a.

* Updating Deviation and Go File
bkreddy143 pushed a commit to nokia/featureprofiles that referenced this pull request Jul 17, 2024
@rahulsy26 @bkreddy143
[FNT] Forwarding viability Test aggregate_all_not_viable_test (openco…
d5b63f3 
…nfig#2953)

* Updating Metadata

* Revert "Updating Metadata"

This reverts commit 45c5e722786ceee387fb74f763ea5a685b07dc80.

* Reapply "Updating Metadata"

This reverts commit d8bc4adba96589aa6e6f109a5ea2679f4621ae8a.

* Updating Deviation and Go File
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dplore dplore dplore left review comments

@self-maurya self-maurya self-maurya approved these changes

@michaelore michaelore Awaiting requested review from michaelore michaelore was automatically assigned from openconfig/featureprofiles-maintainers-otg

@LimeHat LimeHat Awaiting requested review from LimeHat

@Ankur19 Ankur19 Awaiting requested review from Ankur19

@nachikethas nachikethas Awaiting requested review from nachikethas

@nflath nflath Awaiting requested review from nflath

@bkreddy143 bkreddy143 Awaiting requested review from bkreddy143

Assignees

@nflath nflath

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@rahulsy26 @OpenConfigBot @coveralls @LimeHat @nflath @nachikethas @dplore @self-maurya @bkreddy143