gNOI-3.3: add new subtests for configuration convergence #2830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Functional Test Report for #2830 / 641da8eVirtual Devices
Hardware Devices
|
Pull Request Test Coverage Report for Build 8820903594Details
💛 - Coveralls |
|
Can you please add
Thanks, |
|
Thanks for the updates @kjahed I'm wondering if these subtests belong to gNOI-3.3? Specifically for the second case, configuration convergence, there's a separate test gNMI-1.19 |
dplore
reviewed
Apr 26, 2024
Comment on lines
+9
to
+15
| * Basic Switchover | ||
| * Issue gnoi.SwitchControlProcessor to the chassis with dual supervisor, | ||
| specifying the path to choose the standby RE/SUP. | ||
| * Ensure the SwitchControlProcessorResponse has the new active supervisor as | ||
| the one specified in the request. | ||
| * Validate the standby RE/SUP becomes the active after switchover | ||
| * Validate that all connected ports are re-enabled. |
There was a problem hiding this comment.
Suggested change
| * Basic Switchover | |
| * Issue gnoi.SwitchControlProcessor to the chassis with dual supervisor, | |
| specifying the path to choose the standby RE/SUP. | |
| * Ensure the SwitchControlProcessorResponse has the new active supervisor as | |
| the one specified in the request. | |
| * Validate the standby RE/SUP becomes the active after switchover | |
| * Validate that all connected ports are re-enabled. | |
| * gNOI-3.3.1 Basic Switchover | |
| * Issue gnoi.SwitchControlProcessor to the chassis with dual `CONTROLLER_CARD`, | |
| specifying the path to choose the standby RE/SUP. | |
| * Ensure the SwitchControlProcessorResponse has the new active `CONTROLLER_CARD` as | |
| the one specified in the request. | |
| * Validate the standby `CONTROLLER_CARD` becomes the active after switchover | |
| * Validate that all connected ports are re-enabled. |
Comment on lines
+17
to
+25
| * Configuration consistent after switchover | ||
| * Get the configuration before switchover. | ||
| * Perform and validate switchover using the process outlined above. | ||
| * Get configuration after switchover and validate that it matches the pre-switchover configuration. | ||
|
|
||
| * Configuration convergence after switchover | ||
| * Perform and validate switchover using the process outlined above. | ||
| * Push a large configuration | ||
| * Get the configuration and validate that it is accepted whithin 60 seconds. |
There was a problem hiding this comment.
I think these steps should be moved to gNMI-1.19?
I think this portion of the test is duplicate with gnmi-1.19? The implementation should probably be moved here instead:
There was a problem hiding this comment.
Ack. Will close this and open a new PR for gNMI-1.19.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following subtests:
1- TestConfigurationUnchanged checks that the configuration is unchanged after switchover
2- TestConfigurationConvergence checks that a large configuration is accepted within 60 seconds after switchover
Also adds a Reporter to collect diff entries from cmp.Diff. This allows the test to examine the each diff to decide whether, for e.g., the configuration match. In this enhanced switchover test, this is used to ignore leaves that are not explicitly configured (i.e., fields with nil value) when comparing against the configuration returned from the device.