Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for 400ZR transceiver low power mode setting. #2621

Merged
merged 5 commits into from
Feb 7, 2024
Merged

Conversation

ahsaanyousaf
Copy link
Contributor

Add a test for 400ZR transceiver low power mode setting.

@ahsaanyousaf ahsaanyousaf requested a review from a team as a code owner February 5, 2024 01:54
@ahsaanyousaf ahsaanyousaf requested a review from a team February 5, 2024 01:54
@OpenConfigBot
Copy link

OpenConfigBot commented Feb 5, 2024

Pull Request Functional Test Report for #2621 / ab74251

No tests identified for validation.

Help

@coveralls
Copy link

coveralls commented Feb 5, 2024

Pull Request Test Coverage Report for Build 7806109693

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 52.141%

Totals Coverage Status
Change from base Build 7805333167: 0.0%
Covered Lines: 1668
Relevant Lines: 3199

💛 - Coveralls

@ahsaanyousaf ahsaanyousaf requested a review from dplore February 6, 2024 06:23
@dplore dplore merged commit 066ccf7 into main Feb 7, 2024
13 checks passed
@dplore dplore deleted the low-power-mode branch February 7, 2024 19:18
* Typical test setup for this test is a DUT1 with 2 ports to 2 ATE ports or 2
ports to a second DUT2. For most tests this setup should be sufficient.
Ref: [Typical ATE<>DUT Test bed](https://github.com/openconfig/featureprofiles/blob/main/topologies/atedut_2.testbed)
* A and Z ends of the link should have same 400ZR PMD. For this test a
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, extra space after "of"


* /interfaces/interface/config/enabled

* In low power mode the module's Management interface should be available,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional, but are we going too deep into CMIS jargon here when this is an OpenConfig test? Could we essentially delete this bullet and the following one without losing any intent of this test?

frasieroh pushed a commit to aristanetworks/openconfig-featureprofiles that referenced this pull request Feb 9, 2024
…2621)

* Add a test for 400ZR transceiver low power mode setting.
bkreddy143 pushed a commit to nokia/featureprofiles that referenced this pull request Jul 17, 2024
…2621)

* Add a test for 400ZR transceiver low power mode setting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants