Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TE-11.3,RT-1.10: configure default NI name #2548

Merged
merged 4 commits into from
Feb 16, 2024
Merged

TE-11.3,RT-1.10: configure default NI name #2548

merged 4 commits into from
Feb 16, 2024

Conversation

kjahed
Copy link
Contributor

@kjahed kjahed commented Jan 15, 2024

Use fptest.ConfigureDefaultNetworkInstance to make sure NI name is configured when replacing default NI.

@kjahed kjahed requested review from a team as code owners January 15, 2024 22:18
@kjahed kjahed requested review from a team and thesrinath January 15, 2024 22:18
@OpenConfigBot
Copy link

OpenConfigBot commented Jan 15, 2024 •
edited
Loading

Pull Request Functional Test Report for #2548 / 3b1fd4d

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
 RT-1.10: BGP Keepalive and HoldTimer Configuration Test
Cisco 8000E status
 RT-1.10: BGP Keepalive and HoldTimer Configuration Test
Cisco XRd status
 RT-1.10: BGP Keepalive and HoldTimer Configuration Test
Juniper cPTX status
 RT-1.10: BGP Keepalive and HoldTimer Configuration Test
Juniper ncPTX status
 RT-1.10: BGP Keepalive and HoldTimer Configuration Test
Nokia SR Linux status
 RT-1.10: BGP Keepalive and HoldTimer Configuration Test
Openconfig Lemming status
 RT-1.10: BGP Keepalive and HoldTimer Configuration Test

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
 RT-1.10: BGP Keepalive and HoldTimer Configuration Test
Cisco 8808 status
 RT-1.10: BGP Keepalive and HoldTimer Configuration Test
Juniper PTX10008 status
 RT-1.10: BGP Keepalive and HoldTimer Configuration Test
Nokia 7250 IXR-10e status
 RT-1.10: BGP Keepalive and HoldTimer Configuration Test

Help

@AmrNJ
Copy link
Contributor

AmrNJ commented Feb 12, 2024

Please can you rebase?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7874829035

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 52.281%
Totals Coverage Status
Change from base Build 7869443570: 0.0%
Covered Lines: 1673
Relevant Lines: 3200
💛 - Coveralls

@self-maurya self-maurya merged commit dd9eed3 into openconfig:main Feb 16, 2024
11 checks passed
frasieroh pushed a commit to aristanetworks/openconfig-featureprofiles that referenced this pull request Feb 16, 2024
@kjahed @frasieroh
TE-11.3,RT-1.10: configure default NI name (openconfig#2548)
3e93bd1 
* use util function to configure default ni

* revert benchmarking test
ANISH-GOTTAPU pushed a commit to open-traffic-generator/featureprofiles that referenced this pull request Jul 10, 2024
@kjahed @ANISH-GOTTAPU
TE-11.3,RT-1.10: configure default NI name (openconfig#2548)
c0c7c4d 
* use util function to configure default ni

* revert benchmarking test
bkreddy143 pushed a commit to nokia/featureprofiles that referenced this pull request Jul 17, 2024
@kjahed @bkreddy143
TE-11.3,RT-1.10: configure default NI name (openconfig#2548)
eb2eab5 
* use util function to configure default ni

* revert benchmarking test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@self-maurya self-maurya self-maurya approved these changes

@thesrinath thesrinath Awaiting requested review from thesrinath thesrinath was automatically assigned from openconfig/featureprofiles-maintainers-otg

Assignees
No one assigned
Labels
cisco-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kjahed @OpenConfigBot @AmrNJ @coveralls @self-maurya