OTG Test - Gnmi-1.5 Telemetry: Port Speed Test #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Functional Test Report for #2297 / 17f3aabVirtual Devices
Hardware Devices
|
Pull Request Test Coverage Report for Build 7630885172
💛 - Coveralls |
jasdeep-hundal
requested changes
Jan 5, 2024
feature/gnmi/otg_tests/telemetry_port_speed_test/telemetry_port_speed_test.go
Outdated
Show resolved
Hide resolved
feature/gnmi/otg_tests/telemetry_port_speed_test/telemetry_port_speed_test.go
Outdated
Show resolved
Hide resolved
feature/gnmi/otg_tests/telemetry_port_speed_test/telemetry_port_speed_test.go
Outdated
Show resolved
Hide resolved
feature/gnmi/otg_tests/telemetry_port_speed_test/telemetry_port_speed_test.go
Outdated
Show resolved
Hide resolved
feature/gnmi/otg_tests/telemetry_port_speed_test/telemetry_port_speed_test.go
Outdated
Show resolved
Hide resolved
jasdeep-hundal
requested changes
Jan 19, 2024
Comment on lines
323
to
329
| val, status := gnmi.Watch(t, tc.dut, gnmi.OC().Interface(tc.aggID).Aggregation().LagSpeed().State(), 60*time.Second, func(val *ygnmi.Value[uint32]) bool { return val.IsPresent() }).Await(t) | ||
| if status { | ||
| if got, _ := val.Val(); int(got) != want { | ||
| t.Errorf("Get(DUT port status): got %v, want %v", got, want) | ||
| } | ||
| } else { | ||
| t.Errorf("Timeout waiting for the Lagspeed value") |
There was a problem hiding this comment.
@octpetre : Thinking we directly compare in the Await
got, ok := gnmi.Watch(t, tc.dut, gnmi.OC().Interface(tc.aggID).Aggregation().LagSpeed().State(), 60*time.Second, func(val *ygnmi.Value[uint32]) bool {
speed, ok := val.Val()
return ok && speed == want
}).Await(t)
if !ok {
t.Errorf("Get(DUT port status): got %v, want %v", got, want)
}
jasdeep-hundal
approved these changes
Jan 24, 2024
frasieroh
pushed a commit
to aristanetworks/openconfig-featureprofiles
that referenced
this pull request
Jan 24, 2024
* initial ATE test copy * otg related changes * removed the ate command * PR reviews addressed * removed the deviation for setting the link down in kne * PR review addressed
bkreddy143
pushed a commit
to nokia/featureprofiles
that referenced
this pull request
Jul 17, 2024
* initial ATE test copy * otg related changes * removed the ate command * PR reviews addressed * removed the deviation for setting the link down in kne * PR review addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The otg version of this test.
Resolves #581