User defined VxLAN UDP source port calculation

[marian-pritsak]

No description provided.

[itaibaz]

should we also add per tunnel attrib ?
as original attributes are both per {switch, tunnel type} and {tunnel}
otherwise, we may need to specify this mode is not per tunnel

[JaiOCP]

Have you looked at PR#1173. It added following attributes
/**

• @brief Defines VXLAN tunnel UDP source port mode
  /
  typedef enum _sai_tunnel_vxlan_udp_sport_mode_t
  {
  /*

  • @brief User define value
    */
    SAI_TUNNEL_VXLAN_UDP_SPORT_MODE_USER_DEFINED,

  /**

  • @brief RFC6335 Computed hash value in range 49152-65535
    */
    SAI_TUNNEL_VXLAN_UDP_SPORT_MODE_EPHEMERAL,
    } sai_tunnel_vxlan_udp_sport_mode_t;

[marian-pritsak]

should we also add per tunnel attrib ?
as original attributes are both per {switch, tunnel type} and {tunnel}
otherwise, we may need to specify this mode is not per tunnel

It doesn't make sense at the moment to have it per tunnel. If anyone will come up with the use case, it can be added.

[marian-pritsak]

Have you looked at PR#1173. It added following attributes
/**

• @brief Defines VXLAN tunnel UDP source port mode
  _/
  typedef enum sai_tunnel_vxlan_udp_sport_mode_t
  {
  /*

  • @brief User define value
    */
    SAI_TUNNEL_VXLAN_UDP_SPORT_MODE_USER_DEFINED,

  /**

  • @brief RFC6335 Computed hash value in range 49152-65535
    */
    SAI_TUNNEL_VXLAN_UDP_SPORT_MODE_EPHEMERAL,
    } sai_tunnel_vxlan_udp_sport_mode_t;

"Ephemeral" is not flexible enough

[marian-pritsak]

should we also add per tunnel attrib ?
as original attributes are both per {switch, tunnel type} and {tunnel}
otherwise, we may need to specify this mode is not per tunnel

It doesn't make sense at the moment to have it per tunnel. If anyone will come up with the use case, it can be added.

I misunderstood a comment - yes, it should be in both since the enum is shared

[lguohan]

can be merged into user_defined mode

[marian-pritsak]

Done

[rlhui]

@JaiOCP - would you like to review/approve?

[lguohan]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[JaiOCP]

@JaiOCP - would you like to review/approve
Changes looks good