Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idiom stuff #751

Merged
merged 8 commits into from
Apr 24, 2018
Merged

Idiom stuff #751

merged 8 commits into from
Apr 24, 2018

Conversation

ampli
Copy link
Member

@ampli ampli commented Apr 24, 2018

Main changes:

  • Allow subscripted idioms, which is not too useful in general, but it allows to use .# corrections.
  • Idiom support in the link-parser !!string command, such as !!but_*.
  • Test ability to detect duplicate idioms (comes for free due to the insertion of idioms to the dict).

ampli added 8 commits April 24, 2018 20:36
1. Remove forbidding subscript on a idioms in the dict.
2. Add subscript "I%d" in a addition to a possibly existing subscript.
3. When checking for an idiom component word, check the leftmost subscript.
4. When removing an idiom subscript, remove only the added "I%d".
This allows:
1. Find unintended duplicate definitions.
2. Look them up using "!!", as in "!!a_lot" .
3. Using idioms as corrections in ".#".
So by default nothing happens and duplicate idioms are permitted
as before.
This allows something like:
rather_then.#rather_than: rather_than;
@ampli ampli mentioned this pull request Apr 24, 2018
@linas linas merged commit d86858e into opencog:master Apr 24, 2018
@ampli ampli deleted the idiom branch May 26, 2018 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants