Changes summaries to use a fractional threshold rather than absolute #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Can you rebase your branch on the latest devel, please? That should have taken care of the AppVeyor problems. |
ac587e5 to
d8a23c4
Compare
Codecov Report
@@ Coverage Diff @@
## devel #689 +/- ##
==========================================
+ Coverage 81.66% 81.78% +0.11%
==========================================
Files 36 36
Lines 3644 3645 +1
Branches 832 832
==========================================
+ Hits 2976 2981 +5
+ Misses 474 470 -4
Partials 194 194
Continue to review full report at Codecov.
|
Midnighter
approved these changes
Apr 25, 2018
|
No worries, thanks for fixing the appveyor builds! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generalizes better to models that have a wide range of different flux values.