Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace our spinner with appkits spinner #1390

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Replace our spinner with appkits spinner #1390

merged 4 commits into from
Dec 17, 2024

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Jun 26, 2024

This changes is so we use the spinner component from appkit instead of animating an icon ourselves.
Helps with #1381.

Before:
Bildschirmfoto vom 2024-06-26 17-13-50
After:
Bildschirmfoto vom 2024-06-26 17-13-29

@Arnei
Replace our spinner with appkits spinner
3012319 
This changes is so we use the spinner component
from appkit instead of animating an icon ourselves.
@Arnei Arnei added the type:visual-clarity A part of the UI is not visually readable label Jun 26, 2024
@github-actions GitHub Actions
Copy link

This pull request is deployed at test.editor.opencast.org/1390/2024-06-26_15-33-47/ .
It might take a few minutes for it to become available.

@github-actions github-actions bot added the status:conflicts Conflicts with another pull request or issue label Dec 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions github-actions bot removed the status:conflicts Conflicts with another pull request or issue label Dec 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

This pull request is deployed at test.editor.opencast.org/1390/2024-12-06_08-11-10/ .
It might take a few minutes for it to become available.

@github-actions github-actions bot added the status:conflicts Conflicts with another pull request or issue label Dec 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions github-actions bot removed the status:conflicts Conflicts with another pull request or issue label Dec 10, 2024
@github-actions GitHub Actions
Copy link

This pull request is deployed at test.editor.opencast.org/1390/2024-12-10_08-18-58/ .
It might take a few minutes for it to become available.

@github-actions github-actions bot added the status:conflicts Conflicts with another pull request or issue label Dec 17, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@geichelberger geichelberger self-assigned this Dec 17, 2024
@github-actions github-actions bot removed the status:conflicts Conflicts with another pull request or issue label Dec 17, 2024
@github-actions GitHub Actions
Copy link

This pull request is deployed at test.editor.opencast.org/1390/2024-12-17_08-16-33/ .
It might take a few minutes for it to become available.

@geichelberger geichelberger merged commit 5680817 into opencast:main Dec 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geichelberger geichelberger geichelberger approved these changes

Assignees

@geichelberger geichelberger

Labels
type:visual-clarity A part of the UI is not visually readable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arnei @geichelberger