-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify Scheduling pages #911
Conversation
Use Run test server using develop.opencast.org as backend:
Specify a different backend like stable.opencast.org:
It may take a few seconds for the interface to spin up. |
Reduces duplicate code between the scheduling page for creating a new event and for editing events. Functionality should be unchanged.
ebb3d24
to
998e31b
Compare
This pull request is deployed at test.admin-interface.opencast.org/911/2025-01-21_07-58-59/ . |
I have done some tests with this PR and found some problems:
|
Thanks for testing! Did the problems you found also occur without this PR? (I think I've seen the start date field being empty on another branch before, but I'm not sure) This PR does not intend to change functionality. To fix #941, a seperate PR would be better. (Getting this merged should make fixing it easier though) |
I did another test with the actual main branch and I have the same problem there. But on our test system with the opencast-admin-interface release from 2024-07-12 installed, I don't have this problem. The date is displayed correctly there. So somehow this bug was introduced afterwards.
Ok, I just wanted to make sure we don't forget about this issue (and don't reintroduce it later on). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing symbols:
> tsc && eslint . --max-warnings=0 && vite build
src/components/events/partials/ModalTabsAndPages/NewSourcePage.tsx:445:18 - error TS2304: Cannot find name 'currentLanguage'.
445 locale={currentLanguage?.dateLocale}
~~~~~~~~~~~~~~~
src/components/events/partials/ModalTabsAndPages/NewSourcePage.tsx:475:20 - error TS2304: Cannot find name 'currentLanguage'.
475 locale={currentLanguage?.dateLocale}
~~~~~~~~~~~~~~~
Found 2 errors in the same file, starting at: src/components/events/partials/ModalTabsAndPages/NewSourcePage.tsx:445
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't reproduce this. The missing symbols are not present in the NewSourcePage.tsx?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They're not in the diff, they're in the origin/main
. I'm guessing main
drifted underneath this PR.
Fixes #221
Reduces duplicate code between the scheduling page for creating a new event and for editing events.
Functionality should be unchanged.