Add unsaved changes warning in event details #1081
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a generic modal component and replaces existing modal code with the new component. This intention here is to reduce code duplication and to make future generic changes to modals (i.e. focus trapping) easier.
The introduction of the new modal component broke the confirmation modal that appeared when you had unsaved changes in your events or series details access policy tab. Should now be restored.
Adds a confirmation modal that warns about unsaved changes to the following tabs of the event details: Metadata, Extended Metadata, Scheduling (for scheduled events), Workflows (for scheduled events). Thereby this fixes opencast#982. Includes opencast#1046, because I was expecting this to be tightly related to modals and did not want to write it twice. The general coding approach would be the same though. Speaking of approach, I would like feedback on if this makes for a good approach, or if there are better alternatives I've missed. If people agree with this approach it could then be extended to other modals (e.g. series) as well.
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
|
This pull request is deployed at test.admin-interface.opencast.org/1081/2025-01-23_15-56-50/ . |
|
This pull request has conflicts ☹ |
|
This pull request has conflicts ☹ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a confirmation modal that warns about unsaved changes to the following tabs of the event details:
Metadata,
Extended Metadata,
Scheduling (for scheduled events),
Workflows (for scheduled events).
Thereby this fixes #982.
Includes #1046, because I was expecting this to be tightly related to modals and did not want to write it twice. The general coding approach would be the same though.
Speaking of approach, I would like feedback on if this makes for a good approach, or if there are better alternatives I've missed. If people agree with this approach it could then be extended to other modals (e.g. series) as well.
Possible future improvements (for another PR?): Currently you are only warned about unsaved changes if you try to close the modal. However, changes are also lost if you switch between tabs (e.g. from Metadata to Assets). Maybe there should be a warning there as well?
How to test this
Can be tested as usual. Make sure the warning only appears if you actually made changes.