Fix some Tobira integration issues #1078
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, clicking the "edit path" button of a series in the Tobira tab would open the "select target page" menu showing the currently selected path. This changes it to instead open the menu showing the parent path instead. In addition, this will also mark the currently selected page with a checkmark, as long as no other page has been selected.
This does a couple of things: - Notifications will now be shown underneath the table. Every notification is related to adding a new subpage, which is done at the bottom of the table. Moving the notifications closer to that means that missing them becomes a little harder - Selecting a page will change its displayed title to a placeholder saying "Title of series". This will hopefully reduce confusion related to the fact that the page title will be overwritten with the series title. - Entering a valid path for a new subpage will no longer auto-select that page. Since selecting a page will disable the title editing (because of the behaviour explained in the previous point), auto selection lead to the user not being able to change the title anymore. But when a user wants to add mulitiple new subpages as children of one another, only the final child's title will get overwritten. The titles of the other new subpages need to be freely editable.
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
Fixes an issue where (a) the `not_found` notification would not show up in the tobira tab, leaving it completely empty. In addition, the emitted error was never reset, which (b) also broke the tab for events that do get found. (a) happened because we now fetch the event data directly when opening an event modal, to check the overall tobira status. Switching tabs however removes the notification, which is why it needs to be dispatched again when the tobira tab is opened. (b) was probably just an oversight on my end.
2435148 to
4089aa7
Compare
|
This pull request is deployed at test.admin-interface.opencast.org/1078/2025-01-17_10-42-06/ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1065, #1067, #1071 and #1073,
and also another small issue I found while doing this, where
not founderrors weren't being reset and their notifications didn't show up in the right place.For completeness: I also addressed #1064 and #1068. These are related to german translations, which I updated in the crowdin project yesterday.