-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scheduling for negative timezones #1069
Fix scheduling for negative timezones #1069
Conversation
Use Run test server using develop.opencast.org as backend:
Specify a different backend like stable.opencast.org:
It may take a few seconds for the interface to spin up. |
And hopefully all other timezones. The date for a scheduled event should now always be correct, no matter what hour/minute is selected. Aims at fixing opencast#1062.
1b4c565
to
72159e1
Compare
This pull request is deployed at test.admin-interface.opencast.org/1069/2025-01-15_14-42-29/ . |
Being able to schedule events in the past at the very least sounds bad and sounds like it could have been caused by this PR, so I (or someone else) should take a look at that. Thanks for the review! |
Did some quick testing, and it seems like the nitpicks you described already existed before this PR? In which case I would leave them for a separate PR, because this PR is not claiming to fix them and so this PR can get merged faster. |
I can file the relevant nitpicks as issues so they don't get lost. |
And hopefully all other timezones. The date for a new scheduled event should now always be correct, no matter what hour/minute is selected.
Aims at fixing #1062.
How to test this
Can be tested as usual. Try scheduling events with many different dates, hours, minutes, durations and check if it works as intended. Switch timezones if possible.