Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Consolidate About pages, Highlight Maintainers, Consolidate Contributors #2122

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

drwpow
Copy link
Contributor

@drwpow drwpow commented Jan 25, 2025

Changes

Consolidates 4 About pages into one, creates a new “Maintainers” section, and consolidates Contributors into one big grid

CleanShot 2025-01-25 at 16 23 13@2x

CleanShot 2025-01-25 at 16 23 21@2x

How to Review

(See Netlify link)

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

@drwpow drwpow requested a review from a team as a code owner January 25, 2025 23:23
@drwpow drwpow requested a review from gzm0 January 25, 2025 23:23
Copy link

changeset-bot bot commented Jan 25, 2025

⚠️ No Changeset found

Latest commit: 42e6836

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jan 25, 2025

Deploy Preview for openapi-ts ready!

Name Link
🔨 Latest commit 42e6836
🔍 Latest deploy log https://app.netlify.com/sites/openapi-ts/deploys/67957311de2fbe0008a97804
😎 Deploy Preview https://deploy-preview-2122--openapi-ts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@drwpow drwpow force-pushed the update-contributors branch from 9a7502f to eb05e1f Compare January 25, 2025 23:24
Copy link
Contributor

github-actions bot commented Jan 25, 2025

size-limit report 📦

Path Size
packages/openapi-fetch/dist/index.min.js 6.47 KB (0%)

@drwpow drwpow force-pushed the update-contributors branch from eb05e1f to 2a53972 Compare January 25, 2025 23:24
"freshgiammi",
"lukasedw",
"ViktorPontinen",
"kevmo314",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were pretty behind on this list! We’ve far exceeded 100 contributors 🤩

@drwpow drwpow force-pushed the update-contributors branch from 2a53972 to 42e6836 Compare January 25, 2025 23:26
@@ -27,34 +28,49 @@ description: Additional info about this project
- [**Revolt**](https://github.com/revoltchat/api): open source user-first chat platform
- [**Spacebar**](https://github.com/spacebarchat): a free, open source, self-hostable Discord-compatible chat/voice/video platform
- [**Supabase**](https://github.com/supabase/supabase): The open source Firebase alternative.
- [**Twitter API**](https://github.com/twitterdev/twitter-api-typescript-sdk): Official SDK for the Twitter API
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who cares anymore

1. Support converting any valid OpenAPI schema to TypeScript types, no matter how complicated.
1. Generated types should be statically-analyzable and runtime-free (with minor exceptions like [enums](https://www.typescriptlang.org/docs/handbook/enums.html).
1. Generated types should match your original schema as closely as possible, preserving original capitalization, etc.
1. Typegen only needs Node.js to run (no Java, Python, etc.) and works in any environment.
1. Support fetching OpenAPI schemas from files as well as local and remote servers.

## Differences
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: the differences are removed; I debate whether or not these are useful. If we think they are, they should probably go in the intro?

},
{ text: "About", link: "/about" },
{ text: "useSuspenseQuery", link: "/use-suspense-query" },
{ text: "queryOptions", link: "/query-options" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we forgot to add use useInfiniteQuery here @drwpow

Copy link
Contributor Author

@drwpow drwpow Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that’s a good callout thank you! I was running through the docs and noticed there are some formatting differences between all the packages—APIs are not only written differently but also split up across pages. I’ll make sure they’re in the sidebar in a PR that makes everything consistent.

My philosophy is first just write the docs, then worry about formatting and consistency later. Inconsistent docs are a great problem to have—it means a) they exist, and b) multiple people contributed to them, so the most important parts are done


### vs. tRPC
## メインテナー
Copy link
Contributor Author

@drwpow drwpow Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my barely-JLPT5 proficiency led me to make this guess for a new heading. I don’t feel confident trying to write entire sentences though (I would never run something through Google Translate)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants