Document.get_by_uri() returns None on not found

Close #123
openannotation · May 16, 2015 · 42dc78e · 42dc78e
1 parent 684bbfd
commit 42dc78e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/annotator/document.py b/annotator/document.py
@@ -35,7 +35,7 @@ class Document(es.Model):
     def get_by_uri(cls, uri):
         """Returns the first document match for a given URI."""
         results = cls._get_all_by_uris([uri])
-        return results[0] if len(results) > 0 else []
+        return results[0] if len(results) > 0 else None
 
     @classmethod
     def _get_all_by_uris(cls, uris):

diff --git a/tests/test_document.py b/tests/test_document.py
@@ -134,7 +134,10 @@ def test_get_by_uri(self):
 
         doc = Document.get_by_uri("https://peerj.com/articles/53/")
         assert doc
-        assert_equal(doc['title'], "document1") 
+        assert_equal(doc['title'], "document1")
+
+    def test_get_by_uri_not_found(self):
+        assert Document.get_by_uri("bogus") is None
 
     def test_uris(self):
         d = Document({