Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/ci execute condition #641

Merged
merged 2 commits into from
Jan 19, 2023
Merged

fix/ci execute condition #641

merged 2 commits into from
Jan 19, 2023

Conversation

sasaplus1
Copy link
Member

#640 で一部のワークフローの実行条件を修正しましたが、意図した動作でなかったので修正しています。

@sasaplus1 sasaplus1 self-assigned this Jan 19, 2023
@sasaplus1 sasaplus1 requested a review from herablog January 19, 2023 02:15
pull_request_target:
types:
- labeled
- pull_request_target
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

常にpull_request_targetで動作するようにしました。

Comment on lines 12 to 14
github.event.pull_request.head.repo.full_name != github.repository &&
github.event.pull_request.action == 'labeled' &&
contains(github.event.pull_request.labels.*.name, 'allow execute workflow')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここでforkからのPRであればlabeledでしか動作しないように変更しています。

Comment on lines +20 to +21
with:
ref: 'refs/pull/${{ github.event.number }}/merge'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/checkout#518 (comment) の変更を適用してみています。

@sasaplus1 sasaplus1 force-pushed the fix/ci-execute-condition branch from e300df5 to 0f296a4 Compare January 19, 2023 02:43
@sasaplus1 sasaplus1 marked this pull request as ready for review January 19, 2023 02:45
Copy link
Member

@herablog herablog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

エンジニアを褒めるネコ:いいね

@sasaplus1 sasaplus1 merged commit 1078708 into main Jan 19, 2023
@sasaplus1 sasaplus1 deleted the fix/ci-execute-condition branch January 19, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants