Add waffle representation & partial plot #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradal
reviewed
May 25, 2021
| @@ -10,6 +10,15 @@ | |||
| from openalea.mtg.algo import orders | |||
| from openalea.mtg import stat, algo, traversal | |||
|
|
|||
| from pandas.core.groupby.groupby import DataError | |||
There was a problem hiding this comment.
Put first import of standard Python libraries.
Then 3rd party libs.
Then openalea ones (mtg & co)
src/openalea/strawberry/analysis.py
Outdated
|
|
||
| def stage(vid, g): | ||
| _stage = g.property('Stade') | ||
| return next(iter(list(_stage[cid] for cid in g.components(vid) if cid in _stage)), None) |
There was a problem hiding this comment.
Do not get it.
Why not just take the first element?
You do not need to convert it to a list.
And you can use components_iter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The waffle dataframe creation from extracted data works.
The plot partially works: axes & grid spacing are not correctly displayed.
Partial fix of issue #27