-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shell auto-completion #1603
Open
hoonman
wants to merge
76
commits into
openai:main
Choose a base branch
from
Tienbruh:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+38
−0
Open
Changes from 50 commits
Commits
Show all changes
76 commits
Select commit
Hold shift + click to select a range
bf189a9
Added argcomplete to the dependencies
hoonman 01d72f3
Merge pull request #1 from Tienbruh/hoonbranch
hoonman f75f8a5
Added argcomplete to _cli.py
Tienbruh 30f8013
Merge pull request #2 from Tienbruh/tienbranch
Tienbruh 5a7d06e
Added bash command requirement for bash
hoonman f95433c
edit readme structure
hoonman 080a818
Merge pull request #3 from Tienbruh/hoonbranch
hoonman f724c8b
edit readme structure
hoonman f734f73
Merge pull request #4 from Tienbruh/hoonbranch
hoonman 38dc4ad
simplified step to register argcomplete
hoonman 0e74b73
Merge pull request #5 from Tienbruh/hoonbranch
hoonman 9bd76a1
Merge branch 'openai:main' into main
JesusG2022 9ba029d
refactored readme structure
Tienbruh 11f3670
modified ordering of readme sections
Tienbruh 5a65355
Merge pull request #6 from Tienbruh/tienbranch
Tienbruh 9742678
Modified readme to include both temporary and permanent autocomplete …
hoonman f3d9071
Merge pull request #7 from Tienbruh/hoonbranch
hoonman 1ce382c
Added subsection for different shells
hoonman cbb5052
removed global completion command
hoonman f02e7ea
Merge pull request #8 from Tienbruh/hoonbranch
hoonman 016be6e
Fixed vague wording in readme
Tienbruh 0566711
Modified readme layout
Tienbruh bdd7b7b
Merge pull request #9 from Tienbruh/tienbranch
Tienbruh 3c22cda
Fixed readme typo
Tienbruh faa5dd6
Merge pull request #10 from Tienbruh/tienbranch
Tienbruh e112898
Merge pull request #11 from openai/main
hoonman 177fbea
resolve merge conflict with pyproject.toml file
hoonman 4430b99
Merge pull request #13 from Tienbruh/openai-main
hoonman 1c75144
Merge branch 'openai:main' into main
Tienbruh 6a41a59
Merge branch 'openai:main' into main
Tienbruh 5e8ec65
Merge branch 'main' into main
hoonman 9b097bb
Merge branch 'openai:main' into main
Tienbruh 37d90ba
Merge branch 'openai:main' into main
Tienbruh 995a13d
Merge branch 'main' into main
hoonman 3701916
Merge branch 'openai:main' into main
Tienbruh 51d8d52
Merge branch 'main' into main
hoonman 4adbc2d
Merge branch 'openai:main' into main
Tienbruh 361f10d
Moved argcomplete to become an optional dependency
Tienbruh 984a02e
Merge pull request #14 from Tienbruh/tienbranch
hoonman 8e70ec3
add proxy for argcomplete and use it in _cli.py file
hoonman 889c3b9
add argcomplete proxy in the __init__ file
hoonman 8ef585d
add try except block and remove proxy
hoonman ca2bd27
include guide on installing argcomplete optionally
hoonman 77c2841
edit convention and guide on installing autocomplete optionally
hoonman 6d2e5fa
remove unnecessary newline
hoonman 5eda534
Merge pull request #15 from Tienbruh/hoonbranch
Tienbruh 6041733
remove whiteline
hoonman f333c28
Merge branch 'openai:main' into main
Tienbruh 8e8acfc
Merge branch 'openai:main' into main
Tienbruh a78746d
Merge branch 'openai:main' into main
Tienbruh b0d6047
Merge branch 'openai:main' into main
Tienbruh 2f6b763
Merge branch 'openai:main' into main
Tienbruh f7bc7ae
Merge branch 'openai:main' into main
Tienbruh 9ab6959
Merge branch 'openai:main' into main
Tienbruh 938f601
Merge branch 'main' into main
hoonman 3b21b35
Merge branch 'main' into main
hoonman 611e255
Update README.md
Tienbruh 820d86f
Merge branch 'openai:main' into main
Tienbruh 0eb98ca
Refactored README.md for autocompletion instructions
Tienbruh d72b501
Merge branch 'main' into main
hoonman f8df3ff
Merge branch 'main' into main
hoonman c6a76f3
Merge branch 'main' into main
hoonman c8c0b48
Merge branch 'main' into main
hoonman f851ea5
Merge branch 'main' into main
hoonman 60e6486
Merge branch 'main' into main
hoonman f0645a1
Merge branch 'main' into main
hoonman 57a37b4
Merge branch 'main' into main
hoonman 445a287
Merge branch 'main' into main
hoonman 20552fd
Merge branch 'main' into main
hoonman d17e8c9
Merge branch 'main' into main
hoonman 0ca397f
Merge branch 'openai:main' into main
Tienbruh ec79b64
Merge branch 'main' into main
hoonman 39f71d2
Merge branch 'main' into main
hoonman 13c09ea
Merge branch 'openai:main' into main
Tienbruh 3ab6ad9
Merge branch 'main' into main
hoonman 4e5f49c
Merge branch 'main' into main
hoonman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: are there existing docs we could link to here instead of listing out all the possible environments here? maybe argcomplete's docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both temporary and permanent argcomplete activation instructions for Fish and Powershell are available on argcomplete's contrib directory. However, only the temporary activation commands for Bash and Zsh are listed on argcomplete's README file. The commands to activate autocompletion permanently for Bash and Zsh are not found anywhere on argcomplete's docs.
What are your opinions on replacing all the other environment activation instructions with the appropriate links to argcomplete's docs, while keeping these lines for permanent activation on Bash and Zsh?
For Bash:
For Zsh:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @kwhinnery-openai for docs review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @RobertCraigie, we have refactored our section of the readME file to utilize existing documentation from argcomplete. Let us know if anything else needs to be fixed.