-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test refactoring #2427
Test refactoring #2427
Conversation
Well this is spicy, tests pass for 3.7 but the imports go out of whack in 3.8 |
…ortlib.metadata. Also requiring installing importlib_metadata for python 3.8 now. ???????????
DO NOT MERGE YETSoooo I'm super confused. I think I tracked down the error, but I have no clue why it appeared here of all places. @jkterry1 was there any change to the default test environment, dockerfile, anything, during the last few hours? The bug seems to have been lying in the codebase forever if I'm understanding it correctly, so I guess it's possible that moving the tests somehow exposed it? Basically what happens is: The weird part - the registration code uses the I'm guessing the difference is that before, the only usage of this is in With the tests moved, there is the first environment ever in this codebase whose path does not begin with The way I fixed this is basically forcing python 3.8 to still use Update:The same issue appeared in #2428 , so I suspect that my guess was, in fact, wrong. I have even less of an idea how this happened. |
This is regarding #2426 and possibly about some other aspects of refactoring the tests.
I won't necessarily have time to finish all of this right now/very fast, but we'll see how much work this needs.
So very much WIP