Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test case for VideoRecorder #2404

Merged
merged 2 commits into from
Sep 26, 2021
Merged

Update test case for VideoRecorder #2404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a888dfa
Update test case for VideoRecorder
XuehaiPan Sep 11, 2021
78e1edb
Remove closer for VideoRecorder
XuehaiPan Sep 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions gym/wrappers/monitoring/tests/test_video_recorder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
import json
import gc
import os
import shutil
import tempfile
import numpy as np
import time

import gym
from gym.wrappers.monitoring.video_recorder import VideoRecorder, video_recorder_closer
from gym.wrappers.monitoring.video_recorder import VideoRecorder


class BrokenRecordableEnv(object):
Expand All @@ -27,7 +25,13 @@ def test_record_simple():
rec = VideoRecorder(env)
env.reset()
rec.capture_frame()
proc = rec.encoder.proc

assert proc.poll() is None # subprocess is running

rec.close()

assert proc.poll() is not None # subprocess is terminated
assert not rec.empty
assert not rec.broken
assert os.path.exists(rec.path)
Expand All @@ -52,7 +56,11 @@ def record():
return rec_path, proc

rec_path, proc = record()
assert proc.poll() is not None

gc.collect() # do explicit garbage collection for test
time.sleep(5) # wait for subprocess exiting

assert proc.poll() is not None # subprocess is terminated
assert os.path.exists(rec_path)
f = open(rec_path)
assert os.fstat(f.fileno()).st_size > 100
Expand Down
6 changes: 0 additions & 6 deletions gym/wrappers/monitoring/video_recorder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,12 @@
import numpy as np

from gym import error, logger
from gym.utils import closer


def touch(path):
open(path, "a").close()


video_recorder_closer = closer.Closer()


class VideoRecorder(object):
"""VideoRecorder renders a nice movie of a rollout, frame by frame. It
comes with an `enabled` option so you can still use the same code
Expand All @@ -42,7 +38,6 @@ def __init__(self, env, path=None, metadata=None, enabled=True, base_path=None):
self._async = env.metadata.get("semantics.async")
self.enabled = enabled
self._closed = False
self._recorder_id = video_recorder_closer.register(self)

# Don't bother setting anything else if not enabled
if not self.enabled:
Expand Down Expand Up @@ -190,7 +185,6 @@ def close(self):
self.write_metadata()

# Stop tracking this for autoclose
video_recorder_closer.unregister(self._recorder_id)
self._closed = True

def write_metadata(self):
Expand Down