Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elasticsearch datastore support #343

Merged
merged 8 commits into from
Jul 28, 2023
Merged

Elasticsearch datastore support #343

merged 8 commits into from
Jul 28, 2023

Conversation

joemcelroy
Copy link
Contributor

Elasticsearch Provider Support

Extends the work done by @sebastian-montero in #83 and closes
#52

Work completed in addition to PR

  • Integration tests + local docker container for elasticsearch
  • python notebook to run end to end with retrieval plugin
  • Full support for deletion (by all, by id, by metadata filter
  • Can be used by Elasticsearch cloud and local deployments

I will be actively maintaining it on behalf of Elastic.

@joemcelroy joemcelroy changed the title Elasticsearch datastore Elasticsearch datastore support Jul 21, 2023
@joemcelroy
Copy link
Contributor Author

Hey @isafulf, could you please review?

Thanks

@sebastian-montero
Copy link
Contributor

thank you @joemcelroy !

@sebastian-montero sebastian-montero mentioned this pull request Jul 26, 2023
Closed
isafulf
isafulf approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@isafulf isafulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks for adding.

@isafulf isafulf merged commit e8fda70 into openai:main Jul 28, 2023
@joemcelroy joemcelroy deleted the elasticsearch_datastore branch July 28, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isafulf isafulf isafulf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joemcelroy @sebastian-montero @isafulf