Skip to content
This repository has been archived by the owner on Jun 2, 2023. It is now read-only.

Subscriptions #33

Closed
wants to merge 3 commits into from
Closed

Subscriptions #33

wants to merge 3 commits into from

Conversation

rlingineni
Copy link
Contributor

I’m not exactly sure what to do when a change occurs, it currently just
prints to console if a change happens.

Doorbell is very slow (maybe my internet connection, it’s slow with the Ring App too)

Checking in initial set of commits.

rlingineni and others added 2 commits July 2, 2016 19:36
I’m not exactly sure what to do when a change occurs, it currently just
prints to console. Checking in initial set of commits.
@rlingineni
Copy link
Contributor Author

Maybe there can just be a subscribeForStateChange() in the schemas so it's clear they can subscribe to something. They should implement their own custom callback.

@jasongin
Copy link
Contributor

In the updated translator interface design I'm working on, any property can have the ability to notify of state changes. In the current format, those can be mapped to signals.

So I wouldn't worry about this right now; we'll update translators later for the new design.

@tjaffri tjaffri self-assigned this Aug 2, 2016
@tjaffri
Copy link
Contributor

tjaffri commented Aug 2, 2016

I'll take a look and merge. Sorry about the delay.

@tjaffri
Copy link
Contributor

tjaffri commented Aug 17, 2016

just wanted to explain the delay in merging this one... in the dev branch, you will notice significant changes to our directory structure etc... specifically see #53.

Once we are done with those, we will likely need to rebase this PR to the new dir structure and package format. So please hang tight till then, and we will figure out how to merge this one.

@arjun-msft
Copy link
Contributor

Closing this out as we are leveraging PubSubHubBub for notifications.

@arjun-msft arjun-msft closed this Dec 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants