Skip to content
This repository has been archived by the owner on Jun 2, 2023. It is now read-only.

Update the directory structure of translators repo to use reverse URI based names for translators #43

Closed
tjaffri opened this issue Aug 13, 2016 · 1 comment
Assignees
Milestone

Comments

@tjaffri
Copy link
Contributor

tjaffri commented Aug 13, 2016

We currently have folders with the name of the hardware corresponding to each translator (without namespacing) under each schema folder.

E.g. here we have folders like “Philips Hue Light Bulb” and “Osram Lightify Light Bulb”. These names are not namespaced, unlike schema names which are namespaced.

We need to update all the translator names to reverse URI based names, just like the schemas. The name of the hardware and the npm package name should be included in the package.json as description and name, respectively.

This will be a pretty disruptive change for anyone who depends on translators and the current structure of the repo, so we will need to make sure all dependencies are updated at the same time.

@tjaffri tjaffri added 1608-1 and removed 1608-1 labels Aug 13, 2016
@tjaffri tjaffri self-assigned this Aug 13, 2016
@tjaffri tjaffri modified the milestone: 1608-1 Aug 13, 2016
@tjaffri tjaffri changed the title Update the directory structure of translators repo to use revese URI based names for translators Update the directory structure of translators repo to use reverse URI based names for translators Aug 13, 2016
tjaffri added a commit that referenced this issue Aug 15, 2016
Large dir structure changes, resolving #24 and #43
@tjaffri
Copy link
Contributor Author

tjaffri commented Aug 15, 2016

We need some further changes here, based on discussion with @jasongin and @sanjaiganesh

  1. Move all reverse-uri naming schemes to lowercase (schema and translator folder names)
  2. Tweak the names a little to use the "org.opent2t.sample.thermostat.superpopular" convention. This way they are still readable on GitHub but also following a naming hierarchy.

I will send another PR.

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants