-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add env var as credential input in cli #1456
Conversation
d1c4eee
to
ce801c6
Compare
Hello @AvengerMoJo! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2023-12-11 06:12:36 UTC |
f1196aa
to
04cf3f5
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1456 +/- ##
==========================================
- Coverage 31.05% 31.03% -0.02%
==========================================
Files 49 49
Lines 17758 17768 +10
==========================================
Hits 5514 5514
- Misses 12244 12254 +10 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Alex Lau (AvengerMoJo) <alau@suse.com>
04cf3f5
to
778def9
Compare
@AvengerMoJo I finally got to this pull request and I really like the idea of setting credentials through the env vars. I ended up implementing this: #1463. Could you test if #1463 works for you? |
I am pulling your branch to build a customized docker image to test it against src.o.o in gitea and let you know soon . |
#1463 should replace this PR and the function is working in the cli using OSC_CONFIG= , test with gitea action container with the osc patch https://src.opensuse.org/alexlau/bash-custom-action/actions/runs/9 |
#1453
Taking env var as consideration when the osc is being called the first time.
This allows automation in the workflow without depending on an interactive session.
The implementation is simply checking if OSC_USERNAME, OSC_PASSWORD or OSC_CREDENTIAL
is present and prioritized over the interactive input.
README is also updated accordingly.