Win32 fixes #500
Open
Win32 fixes #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Microsoft isn't consistent about the casing of header filenames in the Windows SDK and documentation (e.g. "Windows.h" vs. "windows.h"), but this doesn't matter on a case-insensitive filesystem. If you are cross-compiling for Windows (e.g. using gcc), then the case matters, and is practically controlled by the w32api headers provided by MinGW64 project.
Define SOLV_STATIC_LIB for libsolv_static to avoid an error when building it for Windows: /work/libsolv/win32/getopt.c:11:14: error: variable ‘optind’ definition is marked dllimport /work/libsolv/win32/getopt.c:11:24: error: variable ‘opterr’ definition is marked dllimport /work/libsolv/win32/getopt.c:11:52: error: variable ‘__optreset’ definition is marked dllimport
v2: Also run tests on Windows
28c948f to
d5649ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fb69d751 Fix Windows build with both ENABLED_SHARED and ENABLE_STATICFix #375 when both shared and static libraries are built.
4b453061 Fix casing of "BaseTsd.h" includeFix #436 for the case where cross-compiling to Windows.