feat(livenet): get live image size from TFTP servers #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the current code handles HTTP and FTP headers, parsing `Content-Length`, TFTP servers need a special handling. E.g.: ``` $ curl -sIL tftp://127.0.0.1/leap-15.3/Leap-15.3_appliance.x86_64-1.15.3.iso $ echo $? 8 ``` Being more verbose (`-v`), we can see: ``` $ curl -vsIL tftp://127.0.0.1/leap-15.3/Leap-15.3_appliance.x86_64-1.15.3.iso * Trying 127.0.0.1:69... * Connected to 127.0.0.1 (127.0.0.1) port 69 * set timeouts for state 0; Total 300000, retry 6 maxtry 50 * got option=(tsize) value=(285802496) * tsize parsed from OACK (285802496) * got option=(timeout) value=(6) * got option=(blksize) value=(512) * blksize parsed from OACK (512) requested (512) * Connected for receive * set timeouts for state 1; Total 0, retry 72 maxtry 50 * Closing connection $ echo $? 8 ``` So, in this case, we can ignore the non-zero exit from curl and parse the `tsize` value received. (cherry picked from commit dracut-ng/dracut-ng@93df9ad)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the current code handles HTTP and FTP headers, parsing
Content-Length, TFTP servers need a special handling. E.g.:Being more verbose (
-v), we can see:So, in this case, we can ignore the non-zero exit from curl and parse the
tsizevalue received.(cherry picked from commit dracut-ng/dracut-ng@93df9ad)