Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Complex Types in store_chunk #915

Merged
merged 1 commit into from
Jan 31, 2021

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Jan 29, 2021

Add missing support for complex types in the Python store chunk interfaces of Record_Component.

Follow-up to #639

@ax3l ax3l added frontend: Python3 api: new additions to the API labels Jan 29, 2021
@ax3l ax3l requested a review from franzpoeschel January 29, 2021 22:24
@@ -525,14 +525,13 @@ def makeConstantRoundTrip(self, file_ending):
np.dtype('double'))
self.assertTrue(ms["longdouble"][SCALAR].load_chunk(o, e).dtype
== np.dtype('longdouble'))
if file_ending != "json":
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works now since #885

Add missing support for complex types in the Python store chunk
interfaces of `Record_Component`.
@ax3l ax3l force-pushed the topic-pyStoreChunkComplex branch from 5da69de to 00f7aab Compare January 29, 2021 22:26
@ax3l ax3l merged commit 8ea0645 into openPMD:dev Jan 31, 2021
@ax3l ax3l deleted the topic-pyStoreChunkComplex branch January 31, 2021 22:28
ax3l added a commit that referenced this pull request Feb 2, 2021
Add missing support for complex types in the Python store chunk
interfaces of `Record_Component`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: new additions to the API frontend: Python3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant