-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADIOS2: Write/Put In Sync Mode #777
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see a suggestion inline. For such tweaks, we need to document a bit more background info (when it occurred and what)
This might be based on a misunderstanding, we are currently clarifying. |
OK, since deferred mode will stay in ADIOS and openPMD is not going to run into data corruption issues due to misusing this mode, I will close this pull request. @ax3l |
Sounds good, thanks! The name is not ideal in our API, which is based on a misunderstanding at some point in the past. Our API (as well as ADIOS') does not make a guarantee when things will arrive on disk (the historical meaning of "flush"). It should also not make a guarantee that written data is at this point "consistent to openPMD" - but it sometimes does this as of now. The idea is to trigger completion of the latter with additional We are planning a simple always-sync mode #484 that just |
Using the
Sync
mode for now does: