Support Parallel HDF5 w/ CMake #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
445c8ef to
2eba09c
Compare
Support parallel HDF5 installs that use CMake. The FindHDF5.cmake variable `HDF5_IS_PARALLEL` is called `HDF5_ENABLE_PARALLEL` in hdf5-config.cmake Unfortunately, the `find_package(HDF5 <version>)` check only marks matches in `major.minor` as compatible. Trying to use CMake 3.19+ version ranges min...max does not work either for HDF5 1.10. Also they raise verbose warnings with FindHDF5.cmake . Thus, we restructure the tests, pick up the first found HDF5 and warn/error out with a hint how to set another HDF5 variant. Luckily, we support even ancient HDF5 installs, thus this should not be too inconvenient for users.
2eba09c to
4e2cfd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support parallel HDF5 installs that use CMake.
(e.g. first seen with Spack on macOS: spack/spack#24680)
The
FindHDF5.cmakevariableHDF5_IS_PARALLELis calledHDF5_ENABLE_PARALLELinhdf5-config.cmake.Unfortunately, the
find_package(HDF5 <version>)check only marks matches inmajor.minoras compatible. Trying to use CMake 3.19+ version ranges min...max does not work either for HDF5 1.10. Also they raise verbose warnings with FindHDF5.cmake .Thus, we restructure the tests, pick up the first found HDF5 and warn/error out with a hint how to set another HDF5 variant. Luckily, we support even ancient HDF5 installs, thus this should not be too inconvenient for users.