Wheels: 0.13.4.post0 #1002
Merged
Wheels: 0.13.4.post0 #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for improved blosc support: ornladios/ADIOS2#2592
``` /usr/local/lib/libblosc.a(blosc.c.o): In function `blosc_init.part.9': blosc.c:(.text+0x43e): undefined reference to `pthread_atfork' ```
Better an older ADIOS than no BLOSC support at all.
ax3l
commented
Jun 16, 2021
| @@ -91,21 +92,26 @@ function build_adios2 { | |||
| if [ "$(uname -s)" = "Linux" ] | |||
| then | |||
| EVPATH_ZPL="ON" | |||
| # ADIOS 2.7.1 & Blosc 1.20.1/1.21.0 | |||
| # /usr/local/lib/libblosc.a(blosc.c.o): In function `blosc_init.part.9': | |||
| # blosc.c:(.text+0x43e): undefined reference to `pthread_atfork' | |||
There was a problem hiding this comment.
same problem appears again in my env on summit at import time...
There was a problem hiding this comment.
Maybe we can try (here and for blosc below):
export LDFLAGS="-lpthread -lpthread_nonshared"
https://gitlab.kitware.com/cmake/cmake/-/issues/20709#note_760439
There was a problem hiding this comment.
I think this line in blosc is outdated:
https://github.com/Blosc/c-blosc/blob/7435f28dd08606bd51ab42b49b0e654547becac4/blosc/CMakeLists.txt#L68
Is: CMAKE_THREAD_PREFER_PTHREAD (docs)
Should be: THREADS_PREFER_PTHREAD_FLAG (docs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADIOS: 2.6.0 -> 2.7.1 (Windows: we patch in ornladios/ADIOS2#2746)
Add support for improved blosc support: ornladios/ADIOS2#2592