Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: crashing on sdk level below 18 #757

Merged
merged 1 commit into from
Aug 23, 2017

Conversation

mayank-kgp
Copy link
Contributor

@mayank-kgp mayank-kgp commented Aug 11, 2017

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the MifosStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@mayank-kgp
Copy link
Contributor Author

SDK check should be added while adding StrictMode otherwise the app will crash on SDK level below 18.
Previous PR #735

@mayank-kgp
Copy link
Contributor Author

@droidchef @therajanmaurya Please review this.

@therajanmaurya
Copy link
Member

@mayank-kgp can you please share the crash log.

@mayank-kgp
Copy link
Contributor Author

@therajanmaurya Please see this -
FATAL EXCEPTION: main
java.lang.NoSuchMethodError: android.os.StrictMode$VmPolicy$Builder.detectFileUriExposure
at com.mifos.App.onCreate(App.java:66)

@therajanmaurya
Copy link
Member

@mayank-kgp checkout this https://developer.android.com/reference/android/os/StrictMode.VmPolicy.Builder.html
StrictMode is supporting all APIs above 9.

@mayank-kgp
Copy link
Contributor Author

@therajanmaurya
Copy link
Member

therajanmaurya commented Aug 23, 2017 via email

@mayank-kgp
Copy link
Contributor Author

@therajanmaurya The reason for this bug was android.os.FileUriExposedException which we are getting on API 24+. You can see crash log here -
#734 (comment)

So we don't need to worry about devices of API level 11.
Please refer to the discussion -
#735 (comment)

@therajanmaurya therajanmaurya merged commit 4974cdb into openMF:master Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants