-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: crashing on sdk level below 18 #757
Conversation
SDK check should be added while adding StrictMode otherwise the app will crash on SDK level below 18. |
@droidchef @therajanmaurya Please review this. |
@mayank-kgp can you please share the crash log. |
@therajanmaurya Please see this - |
@mayank-kgp checkout this https://developer.android.com/reference/android/os/StrictMode.VmPolicy.Builder.html |
@therajanmaurya But the method "detectFileUriExposure" is added in API level 18. Please see this link. |
But our app is supporting all devices above 11, how are you going to handle
that.
…On Wed, Aug 23, 2017 at 10:49 AM, MAYANK JINDAL ***@***.***> wrote:
@therajanmaurya <https://github.com/therajanmaurya> But the method
"detectFileUriExposure" is added in API level 18. Please see this link.
https://developer.android.com/reference/android/os/
StrictMode.VmPolicy.Builder.html?utm_campaign=android_
series_strictmode_012116&utm_source=medium&utm_medium=blog#
detectFileUriExposure%28%29
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#757 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFdZQotZE3NS-u-uEeXxdHWmtdlXNl-nks5sa7ZQgaJpZM4O0RXi>
.
--
*Thanks*
*Namaste*
Rajan Maurya
Contact Number : +91 9015090523
Github: https://github.com/therajanmaurya
College: Cluster Innovation Centre, University of Delhi
Student : B.Tech. (Information Technology & Mathematical Innovations)
|
@therajanmaurya The reason for this bug was android.os.FileUriExposedException which we are getting on API 24+. You can see crash log here - So we don't need to worry about devices of API level 11. |
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xml
style template to your code in Android Studio.Run the unit tests with
./gradlew check
to make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.