fix: NPE on generating Individual collectionsheet #733
Conversation
|
@therajanmaurya I've updated the PR as suggested by @droidchef |
| @@ -252,10 +252,12 @@ public void call(PaymentTypeOptions paymentTypeOption) { | |||
| .subscribe(new Action1<ClientCollectionSheet>() { | |||
| @Override | |||
| public void call(ClientCollectionSheet client) { | |||
There was a problem hiding this comment.
Why is the ClientCollectionSheet object called client here ?
There was a problem hiding this comment.
ClientCollectionSheet object refers to the Client specific for CollectionSheet. Since there were already some Client models, I named this one which is specific to the CollectionSheet, as ClientCollectionSheet. That's why I named the variable client.
| @@ -14,6 +15,7 @@ | |||
| private int clientId; | |||
| private String clientName; | |||
|
|
|||
| @Nullable | |||
| private ArrayList<LoanCollectionSheet> loans; | |||
There was a problem hiding this comment.
Why is the LoanCollectionSheet List called loans here ?
There was a problem hiding this comment.
LoanCollectionSheet refers to the Loan related to the CollectionSheet. Again, like ClientCollectionSheet, I named this so to discern it from the normal Loans. It's called loans as this is the identifier which is received in the JSON response.
ebbd3a0 to
d5be048
Compare
|
@droidchef I updated the PR with appropriate variable names. |
|
@tarun0 Please fix the conflicts |
|
@therajanmaurya Fixed. |
Fix #732
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.