Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated NDK and Pass Code Feature #709

Merged
merged 1 commit into from
Jul 25, 2017
Merged

Conversation

mayank-kgp
Copy link
Contributor

@mayank-kgp mayank-kgp commented Jul 1, 2017

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the MifosStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.
    New feature of 4 digit pin #697 and NDK Integration #698

@mayank-kgp mayank-kgp force-pushed the ndk branch 4 times, most recently from 183c752 to 129ffca Compare July 1, 2017 07:22
@mayank-kgp
Copy link
Contributor Author

mayank-kgp commented Jul 1, 2017

@therajanmaurya @puneetkohli521 Please review it.

encryption

@droidchef
Copy link
Member

I suggest we clear Preferences related to pass code authentication when app is killed or after it stays in the background for X minutes and user returns.

@mayank-kgp
Copy link
Contributor Author

@dilpreet96 Please see Ishan's suggestion.

@dilpreet2028
Copy link
Member

@droidchef Are suggesting to show the passcode screen when he comes back to the application from app in background and when we turns on the screen after it was turned off ?

@droidchef
Copy link
Member

@dilpreet96 Precisely yes!

For coming back from Background have a min threshold time, lets say 2 minutes or so because imagine I am using the app and suddenly get a call or have to answer someone on whatsapp, if I return back from there in a minute or 2 I shouldn't have to add the passcode, but if I am out for a time longer than that, you should ask me for my passcode.

@dilpreet2028
Copy link
Member

Thanks for the clarification @droidchef , will be updating the PR soon.

@mayank-kgp mayank-kgp force-pushed the ndk branch 5 times, most recently from b86074b to d0c8d3b Compare July 19, 2017 20:33
@therajanmaurya
Copy link
Member

@mayank-kgp Please add screen shots

@mayank-kgp mayank-kgp force-pushed the ndk branch 2 times, most recently from d1802f1 to 868a25a Compare July 24, 2017 00:32
@mayank-kgp
Copy link
Contributor Author

@therajanmaurya @puneetkohli521 I have updated the GIF. For demo purpose, I have used 5 seconds for showing the passcode screen again if the app is in background. I am keeping 120 seconds in actual implementation as Ishan suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants