-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrated NDK and Pass Code Feature #709
Conversation
183c752
to
129ffca
Compare
@therajanmaurya @puneetkohli521 Please review it. |
I suggest we clear |
@dilpreet96 Please see Ishan's suggestion. |
@droidchef Are suggesting to show the passcode screen when he comes back to the application from app in background and when we turns on the screen after it was turned off ? |
@dilpreet96 Precisely yes! For coming back from Background have a min threshold time, lets say 2 minutes or so because imagine I am using the app and suddenly get a call or have to answer someone on whatsapp, if I return back from there in a minute or 2 I shouldn't have to add the passcode, but if I am out for a time longer than that, you should ask me for my passcode. |
Thanks for the clarification @droidchef , will be updating the PR soon. |
b86074b
to
d0c8d3b
Compare
@mayank-kgp Please add screen shots |
d1802f1
to
868a25a
Compare
@therajanmaurya @puneetkohli521 I have updated the GIF. For demo purpose, I have used 5 seconds for showing the passcode screen again if the app is in background. I am keeping 120 seconds in actual implementation as Ishan suggested. |
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xml
style template to your code in Android Studio.Run the unit tests with
./gradlew check
to make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.
New feature of 4 digit pin #697 and NDK Integration #698