Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Add Support for Hindi Language in the Android Field Officer App #708

Merged
merged 1 commit into from
Dec 29, 2018

Conversation

AbhilashG97
Copy link
Member

@AbhilashG97 AbhilashG97 commented Jun 30, 2017

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the MifosStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

Issue Reference :

#703, #704

After making the changes-

screenshot_20170630-203331

@AbhilashG97
Copy link
Member Author

AbhilashG97 commented Jun 30, 2017

@therajanmaurya, I have completed the translations, please let me know if I have to make any further changes. I'd be glad to make the required changes.

@@ -0,0 +1,544 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<string name="app_name">मीफोसXड्रायड</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, don't change mifosxdroid into hindi. Stay with english name

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@therajanmaurya, I have made the required changes. Please let me know if I have to make any further changes, I'll be happy to do the needful.

@AbhilashG97 AbhilashG97 force-pushed the android-client-704 branch from 735fa26 to 2ecd14d Compare July 4, 2017 04:21
@therajanmaurya
Copy link
Member

@AbhilashG97 can you please fix the conflicts then I will review and merge

@AbhilashG97 AbhilashG97 force-pushed the android-client-704 branch 2 times, most recently from 333961b to 991d56d Compare July 16, 2017 09:44
@AbhilashG97
Copy link
Member Author

@therajanmaurya, I have fixed the conflicts, please let me know if I have to make any further changes.

@droidchef droidchef merged commit d167219 into openMF:master Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants