Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling EditText hint text and items in option menu #580

Merged
merged 2 commits into from
Mar 14, 2017

Conversation

karsai1993
Copy link
Contributor

@karsai1993 karsai1993 commented Mar 14, 2017

Fix: EditText hint text can be read fully.
EditText hint text cannot be read fully.

Fix: Items in option menu are shown in all fragments, only disabled in certain case.
Items in option menu are not stable as they become invisible in certain fragments and after coming back to DashboardActivity, the items in option menu does not get refreshed to the original status.

@therajanmaurya
Copy link
Member

Make sense, Thanks for the PR. Can you please follow the commit style guideline https://github.com/openMF/android-client/wiki/Commit-Style-Guide

@karsai1993 karsai1993 changed the title Handling EditText hint text and items in option menu Fix: Handling EditText hint text and items in option menu Mar 14, 2017
@karsai1993 karsai1993 changed the title Fix: Handling EditText hint text and items in option menu Handling EditText hint text and items in option menu Mar 14, 2017
@karsai1993
Copy link
Contributor Author

@therajanmaurya , understood. I will do so in the future.
As you can see their is another one issue: #476 referenced here. I did so because my solution fixes the problem described there. My explanation is detailed in that issue. Is it a problem from your point of view that I did not wait for your response regarding that issue?

@therajanmaurya
Copy link
Member

therajanmaurya commented Mar 14, 2017

Can you please make the commit message like
fix: {you message}
It will great you can.

@karsai1993
Copy link
Contributor Author

Could you please help how I can edit the commit text? Or you mean that the name of the pull request should be Fix: Handling EditText hint text and items in option menu?

@therajanmaurya
Copy link
Member

therajanmaurya commented Mar 14, 2017

Here you go https://help.github.com/articles/changing-a-commit-message/
First, do git commit --amend and then change the second commit message.
You can find out in the second section of the above link.

@karsai1993
Copy link
Contributor Author

Done, thanks for your help!

@therajanmaurya
Copy link
Member

therajanmaurya commented Mar 14, 2017

Great work so far. I appreciate you. We are happy to have you.
Welcome to community @karsai1993.

@therajanmaurya therajanmaurya merged commit a01ee17 into openMF:master Mar 14, 2017
@karsai1993
Copy link
Contributor Author

Thanks @therajanmaurya . It is my pleasure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants