-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling EditText hint text and items in option menu #580
Conversation
Make sense, Thanks for the PR. Can you please follow the commit style guideline https://github.com/openMF/android-client/wiki/Commit-Style-Guide |
@therajanmaurya , understood. I will do so in the future. |
Can you please make the commit message like |
Could you please help how I can edit the commit text? Or you mean that the name of the pull request should be Fix: Handling EditText hint text and items in option menu? |
Here you go https://help.github.com/articles/changing-a-commit-message/ |
Done, thanks for your help! |
Great work so far. I appreciate you. We are happy to have you. |
Thanks @therajanmaurya . It is my pleasure. |
Fix: EditText hint text can be read fully.
EditText hint text cannot be read fully.
Fix: Items in option menu are shown in all fragments, only disabled in certain case.
Items in option menu are not stable as they become invisible in certain fragments and after coming back to DashboardActivity, the items in option menu does not get refreshed to the original status.