Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix converting date to medium format. #456

Merged
merged 1 commit into from
Mar 14, 2017

Conversation

k4wel
Copy link
Contributor

@k4wel k4wel commented Dec 20, 2016

See #455

@k4wel k4wel force-pushed the medium-date-error-fix branch from bc0015f to 7b9e0dc Compare December 20, 2016 18:47
@therajanmaurya
Copy link
Member

therajanmaurya commented Feb 21, 2017

@typicalgithubuser please post the screen shot.

@k4wel
Copy link
Contributor Author

k4wel commented Feb 22, 2017

@therajanmaurya
locale "ca"

device-2017-02-22-190421

@therajanmaurya
Copy link
Member

Looks good. Can you please follow the commit style guide. check project wiki.
and squash your multiple commits into one.

@k4wel
Copy link
Contributor Author

k4wel commented Feb 22, 2017

@therajanmaurya
Unfortunally, I don`t know how to squash my commit and merge commit with master.
Can you suggest something or should I create new PR?

@therajanmaurya
Copy link
Member

@typicalgithubuser There is many guides. You can follow anyone http://stackoverflow.com/a/5189600/3176277 or https://ariejan.net/2011/07/05/git-squash-your-latests-commits-into-one/. If need any help ping me on gitter.

@k4wel k4wel force-pushed the medium-date-error-fix branch from 69b2ea4 to 7965c35 Compare February 27, 2017 17:46
@k4wel k4wel force-pushed the medium-date-error-fix branch from 7965c35 to 70c94d7 Compare February 27, 2017 18:22
@k4wel
Copy link
Contributor Author

k4wel commented Feb 27, 2017

@therajanmaurya
Thanks for your help. I`ve squashed them and PR is ready to apply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants