refactor: Migrate LoanAccountSummary fragment to compose #2124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backUp backup backup backup
* refactor: refactor About activity to compose * fix : added text style
* refactor: refactor Create new center fragment to compose * fix: fix build fail
migrate dataTable to compose topbar fix removed extra file fix topbar made required changes
…into loan_account_summary_migration # Conflicts: # core/data/src/main/java/com/mifos/core/data/di/DataModule.kt # core/designsystem/src/main/java/com/mifos/core/designsystem/theme/Color.kt # core/designsystem/src/main/java/com/mifos/core/designsystem/theme/MifosTextStyle.kt # feature/client/src/main/res/values/strings.xml # mifosng-android/src/main/java/com/mifos/mifosxdroid/injection/module/RepositoryModule.kt
Aditya-gupta99
requested changes
Jul 3, 2024
core/designsystem/src/main/java/com/mifos/core/designsystem/icon/MifosIcon.kt
Outdated
Show resolved
Hide resolved
|
Give padding 24dp and 24dp from left and right. |
68da110 to
6943837
Compare
remove extra icon added horizontal padding 24.dp fix scale Fix scale
e589a8b to
95a8b85
Compare
@therajanmaurya done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JIRA: https://mifosforge.jira.com/browse/MIFOSAC-184
Screencast_07_03_2024_03.20.36_AM.webm
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.