Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade gradle groovy to kotlin dsl #2062

Merged
merged 3 commits into from
Feb 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
135 changes: 0 additions & 135 deletions build.gradle

This file was deleted.

9 changes: 9 additions & 0 deletions build.gradle.kts
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// Top-level build file where you can add configuration options common to all sub-projects/modules.
plugins {
id("com.android.application") version "8.1.2" apply false
id("org.jetbrains.kotlin.android") version "1.8.20" apply false
id("com.google.dagger.hilt.android") version "2.44" apply false
id("com.android.library") version "8.1.2" apply false
id("org.jetbrains.kotlin.plugin.serialization") version "1.5.21" apply false
id("androidx.navigation.safeargs") version "2.6.0" apply false
}
38 changes: 0 additions & 38 deletions config/quality/quality.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,11 @@
*/

apply plugin: 'checkstyle'
apply plugin: "com.github.spotbugs"
apply plugin: 'pmd'

dependencies {
checkstyle 'com.puppycrawl.tools:checkstyle:6.5'
}
spotbugs {
toolVersion = '4.7.0'
}

def qualityConfigDir = "$project.rootDir/config/quality"
def reportsDir = "$project.buildDir/reports"
Expand All @@ -32,7 +28,6 @@ task checkstyle(type: Checkstyle, group: 'Verification', description: 'Runs code
include '**/*.java'

reports {
xml.enabled = true
xml {
destination file("$reportsDir/checkstyle/checkstyle.xml")
}
Expand All @@ -41,37 +36,6 @@ task checkstyle(type: Checkstyle, group: 'Verification', description: 'Runs code
classpath = files( )
}

tasks.matching {task -> task.name.startsWith('spotbugs')}.forEach {
check.dependsOn it
it.dependsOn(['compileDebugSources','compileReleaseSources'])
it.group('Verification')
it.description('Inspect java bytecode for bugs')

it.ignoreFailures = false
it.effort = "max"
it.reportLevel = "high"
it.excludeFilter = new File("$qualityConfigDir/findbugs/android-exclude-filter.xml")
it.classes = files("$project.rootDir/mifosng-android/build/intermediates/javac")

it.source 'src'
it.include '**/*.java'
it.exclude '**/gen/**'

it.reports {
xml.enabled = false
html.enabled = true
xml {
destination file("$reportsDir/findbugs/findbugs.xml")
}
html {
destination file("$reportsDir/findbugs/findbugs.html")
}
}

it.classpath = files()
}


task pmd(type: Pmd, group: 'Verification', description: 'Inspect sourcecode for bugs') {
ruleSetFiles = files("$qualityConfigDir/pmd/pmd-ruleset.xml")
ignoreFailures = false
Expand All @@ -82,8 +46,6 @@ task pmd(type: Pmd, group: 'Verification', description: 'Inspect sourcecode for
exclude '**/gen/**'

reports {
xml.enabled = true
html.enabled = true
xml {
destination file("$reportsDir/pmd/pmd.xml")
}
Expand Down
3 changes: 2 additions & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#Fri Feb 02 11:29:16 IST 2024
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.1-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.0-bin.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
Loading
Loading