fixed app crashes when the floating button is clicked in the Group client #1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@avinash14022002 Kindly review this PR. |
avivijay19
reviewed
Jun 6, 2023
| (activity as MifosBaseActivity?)!!.replaceFragment(CreateNewClientFragment.newInstance(), | ||
| if(arguments == null) | ||
| { | ||
| (activity as MifosBaseActivity?)!!.replaceFragment(CreateNewClientFragment.newInstance(), |
There was a problem hiding this comment.
please change with respect to null safety
There was a problem hiding this comment.
please change with respect to null safety
use null safety
avivijay19
approved these changes
Jun 8, 2023
avivijay19
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1941
Record_2023-04-11-19-46-32.mp4
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.