Language setting fixed, code reformatted and optimised #1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46421b1 to
f9bbeda
Compare
iamsh4shank
reviewed
Jul 21, 2021
| @@ -16,6 +18,7 @@ import com.mifos.utils.* | |||
| /** | |||
| * Created by mayankjindal on 22/07/17. | |||
| */ | |||
| @Suppress("DEPRECATION") | |||
There was a problem hiding this comment.
Is this required? as you marked the whole file for deprecation.
There was a problem hiding this comment.
I have removed this.
|
Also @danishjamal104 can you check the build fail issue? |
f9bbeda to
929e1cb
Compare
I have checked it, its issue with the GitHub workflow with lint task. The build is successful on my local machine checkout below SS.
|
iamsh4shank
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.